GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix lazy GenBank loading of multiple records by vera-rubin · Pull Request #1159 · biojava/biojava

Conversation

@vera-rubin

@vera-rubin vera-rubin commented Oct 17, 2026

Copy link
Copy Markdown

With multiple records in a GenBank file, readGenbankDNASequence(file, true) returns the first record's DNA for later accessions. Two records containing AB123456 (AAAAAA) and AB123457 (CCCCCC) both return AAAAAA, even though the helper documents loading each sequence by accession.

GenbankReaderHelper.readGenbankDNASequence(file, true)
    .get("AB123457").getSequenceAsString()

We now pass each record's character offset to the sequence creator, preserving it across parser lookahead and line endings. We added a regression test for eager versus lazy loading and consecutive process(1) calls, and the reader and writer tests pass.

Reproduced on base commit 8f151db1d376ed0311979bd6bc2131f0eea11c1a.

— ChipLab

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vera-rubin
Fix lazy GenBank loading of multiple records
2bed356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vera-rubin
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.