GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix: keep the shell directive set by an option or argument handler by MgmClientGuy0 · Pull Request #158 · bombshell-dev/tab

Conversation

MgmClientGuy0 commented Nov 10, 2026

Copy link

Copy Markdown

What does this PR do?

complete() currently resets the shell directive to the hardcoded ShellCompDirectiveNoFileComp after the option handlers had run. Any user that wants to support file or directory completions could not change this.

#97 already proposed falling back to file completion automatically and was closed in favour of letting the user choose. This PR should allow a user to do that. This should be non-breaking. Any existing code still defaults to ShellCompDirectiveNoFileComp.

Type of change

Bug fix
Feature
Refactor (no behavior change)
Documentation
Performance improvement
Tests
Chore (dependencies, CI, tooling)

Checklist

All tests pass (pnpm test)
Files are formatted (pnpm format)
I have added/updated tests for my changes (if applicable)
I have added a changeset

AI-generated code disclosure

This PR includes AI-generated code

Code was generated with Claude Opus 5.5. I have reviewed and understood every line. PRs and potential comments are written by human.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          fix: keep the shell directive set by an option or argument handler

7f7fc32

`complete()` reset `directive` to `ShellCompDirectiveNoFileComp` after the
handlers had run, so a handler could not choose file or directory
completion. Reset it at the start of `parse()` instead: the default stays
`:4`, and a handler can set e.g. `ShellCompDirectiveDefault` or
`ShellCompDirectiveFilterDirs` for its completion request.

changeset-bot Bot commented Nov 10, 2026

Copy link

Copy Markdown

🦋 Changeset detected

Latest commit: 7f7fc32

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@bomb.sh/tab	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.