GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: lazily create async streaming requests by abhinavkr26104 · Pull Request #183 · browserbase/sdk-python

Conversation

@abhinavkr26104

@abhinavkr26104 abhinavkr26104 commented Aug 15, 2026

Copy link
Copy Markdown

Summary

  • defer creation of async streaming request coroutines until the response context manager is entered
  • apply the lazy behavior to both standard and custom streamed response wrappers
  • add regression coverage for discarded context managers and normal enter/close behavior

Why

Creating an async streaming context manager previously allocated a coroutine immediately. Discarding an unentered manager therefore emitted a RuntimeWarning for an unawaited coroutine.

Fixes #175

Testing

  • python -m pytest tests/test_response.py -q -n 0 (30 passed)
  • full suite with Steady: 1220 passed, 8 skipped, plus 4 pre-existing Windows/environment failures tracked in Make the test suite deterministic on Windows and proxied environments #181
  • full suite excluding those four known failures: 1220 passed, 8 skipped, 4 deselected
  • python -m ruff check .
  • python -m mypy src/browserbase/_response.py

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@abhinavkr26104
fix: lazily create async streaming requests
c918753
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Async streaming response wrappers leak an unawaited coroutine when not entered

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@abhinavkr26104
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.