GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: preserve empty query string values by abhinavkr26104 · Pull Request #187 · browserbase/sdk-python

Conversation

@abhinavkr26104

@abhinavkr26104 abhinavkr26104 commented Aug 15, 2026

Copy link
Copy Markdown

Summary

  • omit only None scalar query values
  • preserve supplied empty strings as key=
  • cover top-level, nested, and repeated-array empty values

Why

The serializer converted an empty string to "" and then treated that valid serialized value as absent. APIs can distinguish a missing query key from a present-but-empty key, so callers need to be able to express both.

Fixes #179

Testing

  • python -m pytest tests/test_qs.py -q (11 passed)
  • python -m mypy src/browserbase/_qs.py
  • python -m pyright src/browserbase/_qs.py tests/test_qs.py
  • python -m ruff check src/browserbase/_qs.py tests/test_qs.py
  • python -m ruff format --check src/browserbase/_qs.py tests/test_qs.py
  • full suite: 1217 passed, 8 skipped; 4 pre-existing Windows/environment failures tracked in Make the test suite deterministic on Windows and proxied environments #181

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@abhinavkr26104
fix: preserve empty query string values
2b4910f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Query serializer silently drops empty-string parameters

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@abhinavkr26104
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.