GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: add downloads, export, and type contracts by derekmeegan · Pull Request #206 · browserbase/sdk-python

Conversation

@derekmeegan

@derekmeegan derekmeegan commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Moves the Python SDK contract tests from browserbase/browserbase-stlc-config#39 into this repo's CI, for the one-repo flow.

  • tests/lib/test_downloads.py covers downloads pagination, metadata, deletion, errors, the legacy ZIP endpoint, streaming without eager reads, stream_to_file(), and cancellation, both sync and async.
  • tests/lib/test_sdk_exports.py covers the public exports.
  • tests/lib/sdk_types.py is the type-level contract. pytest doesn't collect it, and ./scripts/lint checks it with pyright.

This is stacked on feat/downloads, the preview build of browserbase/browserbase-stlc-config#75. Retarget it to main after #75 merges. Nothing in it edits generated files, and the preview's own CI already passes.

The tests now use this repo's pytest settings instead of unittest: pytest classes, parametrize in place of subTest, and tmp_path, with every assertion kept. To pass strict pyright, sdk_types.py gained an __all__ for names imported only to prove they exist, and three reads of the not-required project_id carry a rule-specific pyright: ignore. mypy . excludes tests/, so in CI pyright is what checks the type file; running mypy on these files directly also passes.

Locally, ./scripts/lint passes. pytest tests/lib passes 29 tests on Python 3.9 (pydantic v2 and v1) and 3.14. The full ./scripts/test also passes with the mock server.

🤖 Generated with Claude Code

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@derekmeegan @claude
test: add downloads, export, and type contracts
056f126
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@derekmeegan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.