GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: correct SEA binary setup instructions by abhinavkr26104 · Pull Request #360 · browserbase/stagehand-python

Conversation

@abhinavkr26104

@abhinavkr26104 abhinavkr26104 commented Aug 15, 2026 •
edited by cubic-dev-ai Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Summary

  • point missing-binary errors to the existing scripts/download_binary.py helper
  • replace the stale README anchor with the local-development documentation in CONTRIBUTING.md
  • add a regression assertion for both actionable references

Testing

  • uv run --frozen pytest tests/test_sea_binary.py -q (5 passed)
  • uv run --frozen ruff check .
  • uv run --frozen pyright -p .
  • uv run --frozen mypy --platform linux .
  • full Python 3.9 and 3.14 suites run on Windows; only the pre-existing Windows failures addressed by Make byte fixtures checkout-stable and run tests on Windows CI #355 remained

Fixes #353


Summary by cubic

Corrects SEA missing-binary error guidance so local development instructions are accurate. Previously the error pointed to a non-existent script and a stale README anchor; it now references the correct helper script and CONTRIBUTING.md. No behavior change beyond error text.

  • Error now suggests: "uv run python scripts/download_binary.py" (replaces "scripts/download-binary.py").
  • Updates the help link to https://github.com/browserbase/stagehand-python/blob/main/CONTRIBUTING.md.
  • Adds a regression test asserting both the command and link in the error message.

Fixes #353.

Written for commit a25a20e. Summary will update on new commits.

Review in cubic

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@abhinavkr26104
fix: correct SEA binary setup instructions
a25a20e
cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Aug 15, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.
Architecture diagram
sequenceDiagram
    participant Dev as Developer
    participant App as Stagehand App
    participant Resolver as resolve_binary_path()
    participant Env as Environment
    participant FS as File System
    participant Docs as Documentation

    Note over Dev, Docs: SEA Binary Resolution Flow with Corrected Guidance

    Dev->>App: Run stagehand code
    
    App->>Resolver: Call resolve_binary_path()
    
    Resolver->>Env: Check STAGEHAND_SEA_BINARY
    alt Environment variable set
        Env-->>Resolver: Custom binary path
        Resolver->>FS: Use custom binary
        FS-->>Resolver: Binary exists
        Resolver-->>App: Return binary path
    else No environment variable
        Env-->>Resolver: Not set
        Resolver->>FS: Look for default SEA binary
        FS-->>Resolver: File not found
        Note over Resolver, Docs: Error path with corrected instructions
        Resolver->>Resolver: Construct FileNotFoundError
        Resolver-->>Dev: Raise error with guidance
        Note over Dev, Docs: Error message contains corrected details
        Dev->>Docs: Read error message
        Docs-->>Dev: Instructions to run download script
        Dev->>Dev: Run "uv run python scripts/download_binary.py"
        Dev->>FS: Download SEA binary
        FS-->>Dev: Binary available
        Dev->>App: Retry stagehand code
    end

    Note over Dev, Resolver: Regression test validates error message content
    Dev->>Resolver: Test with missing binary
    Resolver-->>Dev: Verify correct script name and CONTRIBUTING.md link
Loading

Re-trigger cubic

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix nonexistent download script and README anchor in missing SEA binary error

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@abhinavkr26104
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.