GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — browser name added in log line by Rohannagariya1 · Pull Request #946 · browserstack/browserstack-cypress-cli

Conversation

@Rohannagariya1

@Rohannagariya1 Rohannagariya1 commented Nov 29, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Previously, the code was structured as:
osAndBrowser = (element.os) ? element.os : "Any OS" + " / " + Utils.capitalizeFirstLetter(element.browser);
In this setup, if element.os was present, the element.browser was getting ignored, which caused it not to be visible in the log line. To address this, I added separate null checks for both os and browser to ensure both values are correctly included in the log output, even if one of them is missing.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Rohannagariya1 and others added 2 commits November 29, 2024 12:16
@Rohannagariya1
browser name added in log line
fbd6770
@Rohannagariya1
Merge branch 'master' into HST_1454_BROWSER_NAME_NOT_VISIBLE
dca32b6
Ankit098
Ankit098 approved these changes Dec 17, 2024
View reviewed changes
khrithik
khrithik approved these changes Dec 18, 2024
View reviewed changes
@Rohannagariya1
Merge branch 'master' into HST_1454_BROWSER_NAME_NOT_VISIBLE
312170f
karanshah-browserstack
karanshah-browserstack requested changes Dec 4, 2025
View reviewed changes
Comment thread bin/helpers/capabilityHelper.js
osBrowser = element.os + "-" + element.browser;
osAndBrowser = (element.os) ? element.os : "Any OS" + " / " + Utils.capitalizeFirstLetter(element.browser);
osAndBrowser =
(element.os ? element.os : "Any OS") +

@karanshah-browserstack karanshah-browserstack Dec 4, 2025

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is failing for automate, please validate.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karanshah-browserstack karanshah-browserstack karanshah-browserstack requested changes
@Ankit098 Ankit098 Ankit098 approved these changes
+1 more reviewer
@khrithik khrithik khrithik approved these changes
Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Rohannagariya1 @khrithik @Ankit098 @karanshah-browserstack
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.