GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — [Python] Export only PyInit_* from macOS extension modules by mmattice · Pull Request #116 · cel-expr/cel-python ConversationEach extension statically links protobuf, abseil and cel-cpp. On macOS, pybind_extension links with only Wrap pybind_extension to add Fixes #115
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsEach extension statically links protobuf, abseil and cel-cpp. On macOS, pybind_extension links with only `-undefined dynamic_lookup`, so those copies are exported, including thousands of weak definitions. dyld coalesces exported weak definitions across every loaded image, so importing cel_expr_python alongside another extension that ships protobuf (e.g. ortools) binds one runtime's code to the other's parse tables and crashes in AddDescriptors at import time. Wrap pybind_extension to add `-Wl,-exported_symbol,_PyInit_<name>` on macOS, matching the isolation Linux already gets from `-Wl,-Bsymbolic`, and add a macOS test that each extension exports only its init function. Fixes cel-expr#115
tbrito-arpio
approved these changes
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This affects me as well and the fix solves it.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers1 more reviewerAt least 1 approving review is required to merge this pull request. Uh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. macOS wheels export bundled protobuf/abseil symbols → segfault on import alongside any other protobuf C++ (e.g. ortools)Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |