GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — [cel-expr-python] Replace leak census with regrtest-style check. by copybara-service[bot] · Pull Request #137 · cel-expr/cel-python

Conversation

copybara-service Bot commented Nov 11, 2026

Copy link

Copy Markdown

[cel-expr-python] Replace leak census with regrtest-style check.

The gc.get_objects() per-type object census in cel_test.py missed
non-GC-tracked objects (str, int, bytes), triggered false positives
on lazily populated runtime caches, and dominated test runtime.

Replace it with a CPython regrtest -R-style repetition check that runs
each test across warm-up and measured iterations, clears internal caches
and collects garbage between runs, and fails if sys.getallocatedblocks()
grows on every measured run (reporting top tracemalloc sites). Remove
the broken duplicate census in cel_parallel_test.py, and fix two C++
refcount leaks surfaced by the new check: unreleased PyObject_Repr
references in py_cel_value.cc and extra/unreleased references in
PyMessageFactory.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

copybara-service Bot force-pushed the test_1019483161 branch from 2353484 to 553bf6b Compare

November 11, 2026 22:38


          [cel-expr-python] Replace leak census with regrtest-style check.

c6c1049

The `gc.get_objects()` per-type object census in `cel_test.py` missed
non-GC-tracked objects (`str`, `int`, `bytes`), triggered false positives
on lazily populated runtime caches, and dominated test runtime.

Replace it with a CPython `regrtest -R`-style repetition check that runs
each test across warm-up and measured iterations, clears internal caches
and collects garbage between runs, and fails if `sys.getallocatedblocks()`
grows on every measured run (reporting top `tracemalloc` sites). Remove
the broken duplicate census in `cel_parallel_test.py`, and fix two C++
refcount leaks surfaced by the new check: unreleased `PyObject_Repr`
references in `py_cel_value.cc` and extra/unreleased references in
`PyMessageFactory`.

PiperOrigin-RevId: 1019483161

copybara-service Bot force-pushed the test_1019483161 branch from 553bf6b to c6c1049 Compare

November 11, 2026 23:52

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.