Description

0xRAG

opened on May 6, 2025

Issue body actions

Hey @s0 👋 Thanks for this working on this, I've been super excited to use the new commitMode API!

I'm running into an error (see here) that only happens when using commitMode: "github-api" and does not happen when using the default commitMode, and I think the error is coming from this line. The error is:

NotFoundError: Could not find 56f9a0bba782dac4d4fc8bd85b013694451fee8c.

The commit does exist though, so I'm thinking it has to do with that call to git.log. Have you seen this error? I also tried adding fetch-depth: 0 to my checkout step, but the same error occurs. LMK if there's more info I can provide, or is there's a way to enable debug logging. Thank you!

Activity

1. 0xRAG commented on May 6, 2025

   

   0xRAG

   on May 6, 2025

   Author

   More actions

   The problem might be this line. My TypeScript project does not live at the root of the repo, so I think this line is causing the issue
2. Andarist

   assigned

   s0

   on May 6, 2025
3. s0 commented on May 6, 2025

   

   s0

   on May 6, 2025

   Member

   More actions

   Hi @0xRAG thanks for the bug report.

   Yep that looks like the culprit. Probably makes sense to implement some type of automatic parent directory traversal that can be used when the repository directory is not specified to search for .git, which would match what the git CLI does. I'll look into it shortly.

   Reacted by Ryan Gilbert
4. s0

   added a commit that references this issue on May 6, 2025

   Allow for easier committing from subdirectories

   This issue will close once commit 604d0d7 is merged into the 'main' branch.

   604d0d7
5. s0 commented on May 6, 2025

   

   s0

   on May 6, 2025

   Member

   More actions

   Drafted a PR here: #33, will work on test coverage later this week before merging

   Reacted by Ryan Gilbert
6. s0

   added 2 commits that reference this issue on May 7, 2025

   Allow for easier committing from subdirectories

   This issue will close once commit 9dcbdc0 is merged into the 'main' branch.

   9dcbdc0

   Allow for easier committing from subdirectories

   This issue will close once commit a81715e is merged into the 'main' branch.

   a81715e
7. s0

   closed this as completedin #33on May 8, 2025
8. s0

   closed this as completedin 92be707on May 8, 2025
9. s0 commented on May 8, 2025

   

   s0

   on May 8, 2025

   Member

   More actions

   @0xRAG The fix is used in the action now, but I'd wait util changesets/action#473 lands, as it will run, but add all changes in your repo and not just the ones in your subdirectory, which is a change in behaviour.
10. 0xRAG commented on May 8, 2025

    

    0xRAG

    on May 8, 2025

    Author

    More actions

    Ah cool, thanks @s0!
11. s0

    added the

    Bug

    issue type on May 9, 2025

Issue actions