GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove APIs and group single entrypoint by bluwy · Pull Request #109 · changesets/ghcommit

Conversation

@bluwy

@bluwy bluwy commented Jun 15, 2026

Copy link
Copy Markdown
Member

I'd like to propose some breaking changes:

  1. Removed commitFilesFromBuffers and commitFilesFromDirectory. Through the recent refactors, you can see that they're a thin wrapper over the core commitFilesFromBase64.

    I don't think it's hard for users to use commitFilesFromBase64 directly, so I'd prefer if we consolidate to that.

  2. Remove subpath exports, only use the main "." entrypoint.

    With exports conditions, it should be possible to split the API for browsers and node in the same subpath. Plus treeshaking works the same with this approach. You get the same small bundle size already if you only use one set of APIs.


Maybe I'd rename commitFilesFromBase64 to something more user-friendly I think, but I'd like to focus on the API trimming for now.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bluwy
Remove APIs and group single entrypoint
7bbaf26
Andarist
Andarist previously approved these changes Jun 15, 2026
View reviewed changes
Comment thread package.json Resolved

Uh oh!

There was an error while loading. Please reload this page.

@bluwy
Update package.json
a606708
@bluwy
bluwy dismissed Andarist’s stale review via a606708 June 15, 2026 10:54
@bluwy
bluwy requested a review from Andarist June 16, 2026 09:38
bluwy
bluwy commented Jun 16, 2026
View reviewed changes
Comment thread package.json Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/index-browser.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

bluwy added 2 commits June 16, 2026 18:00
@bluwy
Apply suggestions from code review
a24e1f3
Co-authored-by: Bjorn Lu <[email protected]>
@bluwy
Format
cf3e3ec
Andarist
Andarist approved these changes Jun 16, 2026
View reviewed changes
@bluwy
bluwy added this pull request to the merge queue Jun 17, 2026
Merged via the queue into main with commit 203f0b7 Jun 17, 2026
11 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bluwy
bluwy deleted the polish-main-api branch June 17, 2026 16:37
@changesets-org-version-bot changesets-org-version-bot Bot mentioned this pull request Jun 17, 2026
Version Packages (next) #101
Merged
@changesets-org-version-bot changesets-org-version-bot Bot mentioned this pull request Jul 27, 2026
Version Packages #124
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Andarist Andarist Andarist approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bluwy @Andarist
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.