GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Support `branch` and `tag` format for `commitChangesFromRepo` `base` by bluwy · Pull Request #111 · changesets/ghcommit

Conversation

@bluwy

@bluwy bluwy commented Jun 18, 2026

Copy link
Copy Markdown
Member

So it's the same API as commitFilesFromBase64. No reason to not support either as long as the branch and tag is locally available for diffing.

I also did some small refactor in core.ts to rename oid to sha as discussed before.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bluwy
Support branch and tag format for commitChangesFromRepo base
45184ca
bluwy
bluwy commented Jun 18, 2026
View reviewed changes
Comment thread src/core.ts
Comment on lines -19 to -21
// For explicit commit bases we don't resolve the base oid from a ref,
// but the shared metadata query still expects a valid qualified ref name.
return "HEAD";

@bluwy bluwy Jun 18, 2026

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is refactored away as we can avoid accessing info.baseRef in this state.

If base: { commit: "123" } is passed, info.baseRef would be null as it doesn't support direct SHAs. This is fine because we're not going to access it anyways in

const baseSha = "commit" in base ? base.commit : getBaseRefSha(info.baseRef);

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bluwy bluwy mentioned this pull request Jun 18, 2026
Rename as sha for tests #112
Merged
Andarist
Andarist approved these changes Jun 18, 2026
View reviewed changes
@bluwy
bluwy added this pull request to the merge queue Jun 18, 2026
Merged via the queue into main with commit 1cf711e Jun 18, 2026
11 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bluwy
bluwy deleted the support-git-ref branch June 18, 2026 15:14
@changesets-org-version-bot changesets-org-version-bot Bot mentioned this pull request Jun 18, 2026
Version Packages (next) #113
Merged
@changesets-org-version-bot changesets-org-version-bot Bot mentioned this pull request Jul 27, 2026
Version Packages #124
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Andarist Andarist Andarist approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bluwy @Andarist
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.