GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove `recursivelyFindRoot` and make `cwd` optional for `commitChangesSinceBase` by bluwy · Pull Request #118 · changesets/ghcommit

Conversation

@bluwy

@bluwy bluwy commented Jun 22, 2026

Copy link
Copy Markdown
Member

In v2, I notice recursivelyFindRoot didn't really change any behaviour in the code, it doesn't enable/disable filtering files from cwd. So I think we can remove it.

Note: In the git command refactor, I accidentally made recursivelyFindRoot meaningful to affect the cwd filtering, as that's what I thought it does, but overall...

I think it's better to consolidate filtering to just the filterFiles function, so it's easier to control and see what gets filtered. I also made cwd optional as it doesn't matter much now where it's executed, except if to run in a different repo.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
bluwy
bluwy commented Jun 22, 2026
View reviewed changes
Comment thread src/git.ts
Comment on lines -174 to +146
return path.resolve(cwd, stdout.trim());
return path.dirname(path.resolve(cwd, stdout.trim()));

@bluwy bluwy Jun 22, 2026

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently this has always returned a path with /.git ending. I have no idea how things just worked but this should have a dirname so it's the actual project root

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Andarist
Andarist previously approved these changes Jun 22, 2026
View reviewed changes
Base automatically changed from rename-apis to main June 22, 2026 09:20
@bluwy
bluwy dismissed Andarist’s stale review June 22, 2026 09:20

The base branch was changed.

bluwy added 2 commits June 22, 2026 17:37
@bluwy
Remove recursivelyFindRoot and make cwd optional
a8122de
@bluwy
Fix test
583b33b
@bluwy
bluwy force-pushed the update-git-api branch from e110f19 to 583b33b Compare June 22, 2026 09:38
@bluwy

bluwy commented Jun 22, 2026

Copy link
Copy Markdown
Member Author

Rebased the branch to main
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Andarist
Andarist approved these changes Jun 22, 2026
View reviewed changes
@bluwy
bluwy added this pull request to the merge queue Jun 22, 2026
Merged via the queue into main with commit e2b975d Jun 22, 2026
11 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bluwy
bluwy deleted the update-git-api branch June 22, 2026 10:09
@changesets-org-version-bot changesets-org-version-bot Bot mentioned this pull request Jun 22, 2026
Version Packages (next) #113
Merged
@changesets-org-version-bot changesets-org-version-bot Bot mentioned this pull request Jul 27, 2026
Version Packages #124
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Andarist Andarist Andarist approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bluwy @Andarist
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.