GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove any use of process.cwd(), and clean up directory options across functions by s0 · Pull Request #40 · changesets/ghcommit

Conversation

@s0

@s0 s0 commented May 9, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR addresses #39 by ntroducing breaking changes to how we require directories to be specified in the arguments to 2 key functions.

Full information in the .changesets folder, but TL;DR:

  • cwd is now used as the directory name in both files (brings consistency with https://github.com/changesets/action)
  • cwd is required (no default use of process.cwd())
  • commitChangesFromRepo args have been simplified to only require 1 directory

fixes #39

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
s0 added 2 commits May 10, 2025 00:43
@s0
Clean up arguments for multiple functions
9deb794 
- Use `cwd` consistently across functions
- Remove unnecessary extra directory args for `commitChangesFromRepo`
- Introduce `recursivelyFindRoot` argument
@s0
Fix node tests
2171089
@s0 s0 mentioned this pull request May 9, 2025
Make repo required & remove deprecated arg #41
Merged
@s0
s0 enabled auto-merge (squash) May 9, 2025 23:51
Andarist
Andarist reviewed May 10, 2025
View reviewed changes
Comment thread .changeset/blue-carpets-jam.md
- For `commitFilesFromDirectory`:
- Rename `workingDirectory` to `cwd` for consistency across repos,
and utils like `exec`
- Make `cwd` a required argument

@Andarist Andarist May 10, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be OK to make this optional and just default to process.cwd(). In changesets/action we'd still provide it explicitly though.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@s0 s0 May 10, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, decided being explicit was probably better anyway, given how easy it is to use process.cwd() if that's what people wanted. 😄

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Andarist
Andarist approved these changes May 10, 2025
View reviewed changes

@Andarist Andarist left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@s0
s0 merged commit 4117e39 into main May 10, 2025
@s0
s0 deleted the repo-args-cleanup branch May 10, 2025 08:51
@github-actions github-actions Bot mentioned this pull request May 10, 2025
Version Packages #43
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Andarist Andarist Andarist approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow for recursive directory search from specific folder

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@s0 @Andarist
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.