GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Modernize GitHub workflows by Andarist · Pull Request #48 · changesets/ghcommit

Conversation

@Andarist

@Andarist Andarist commented Jan 27, 2026

Copy link
Copy Markdown
Member

I've configured trusted publishing for publish.yml so we need to rename this file

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Andarist
Rename workflow files
e246168
@Andarist
Andarist requested review from bluwy and s0 January 27, 2026 07:56
bluwy
bluwy reviewed Jan 27, 2026
View reviewed changes
Comment thread .github/workflows/publish.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Andarist Andarist mentioned this pull request Jan 27, 2026
Version Packages #49
Merged
@Andarist
tweak env vars
34f7bd3
@Andarist Andarist changed the title Rename workflow files Tweak publish workflow file Jan 27, 2026
@Andarist
Andarist requested a review from bluwy January 27, 2026 17:36
bluwy
bluwy previously approved these changes Jan 27, 2026
View reviewed changes

@bluwy bluwy left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know what would be cool? 😅 changesets/action#525

Anyways LGTM now 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
s0
s0 requested changes Jan 27, 2026
View reviewed changes

@s0 s0 left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more changes to probably get this working, see related PRs for getting trusted publishing working in another repo I maintain:

  • ArcaneWizards/arcanejs#106
  • ArcaneWizards/arcanejs#107

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread .github/workflows/publish.yml Outdated
Comment on lines 21 to 23

@s0 s0 Jan 27, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to also upgrade these for trusted publishing to work:

        uses: actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f # v6.1.0
        with:
          node-version: 24.x

See this PR in another repo with an equivalent change: ArcaneWizards/arcanejs#107

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Andarist Andarist Jan 27, 2026

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bumped all actions now

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread .github/workflows/publish.yml Outdated
Comment on lines +39 to +40
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
NPM_CONFIG_PROVENANCE: true

@s0 s0 Jan 27, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
NPM_CONFIG_PROVENANCE: true

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread .github/workflows/publish.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .github/workflows/ci.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Andarist
updade versions
ebab31f
@Andarist
Andarist dismissed bluwy’s stale review via ebab31f January 27, 2026 17:51
@Andarist Andarist changed the title Tweak publish workflow file Modernize GitHub workflows Jan 27, 2026
s0
s0 approved these changes Jan 27, 2026
View reviewed changes
@s0
s0 enabled auto-merge (squash) January 27, 2026 17:52
@Andarist
Andarist requested a review from s0 January 27, 2026 17:52
s0
s0 approved these changes Jan 27, 2026
View reviewed changes
@Andarist
Merge branch 'main' into rename-workflow-files
e4d11f4
@s0
s0 merged commit 8d5d614 into main Jan 27, 2026
4 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@s0
s0 deleted the rename-workflow-files branch January 27, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@s0 s0 s0 approved these changes
@bluwy bluwy bluwy left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Andarist @s0 @bluwy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.