GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [ISSUE #560]Optimize BaseCloudEvent#readExtensions method by mxsm · Pull Request #561 · cloudevents/sdk-java

Conversation

@mxsm

@mxsm mxsm commented Apr 29, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fix #560
Optimize BaseCloudEvent#readExtensions method

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mxsm
[ISSUE cloudevents#560]Optimize BaseCloudEvent#readExtensions method
d174d8d 
Signed-off-by: mxsm <[email protected]>
pierDipi
pierDipi reviewed May 10, 2023
View reviewed changes
Comment thread core/src/main/java/io/cloudevents/core/impl/BaseCloudEvent.java
writer.withContextAttribute(entry.getKey(), (byte[]) entry.getValue());
Object value = entry.getValue();
if (value instanceof String || value instanceof Number || value instanceof Boolean || value instanceof URI) {
writer.withContextAttribute(entry.getKey(), value.toString());

@pierDipi pierDipi May 10, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the .toString() is not equivalent to previous implementation that was using typed methods.

The original issue is not clear what the optimization is?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierDipi pierDipi pierDipi left review comments

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Optimize BaseCloudEvent#readExtensions method

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@mxsm @pierDipi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.