GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(amqp): read cloudEvents_ application properties by Adrastopoulos · Pull Request #757 · cloudevents/sdk-java

Conversation

@Adrastopoulos

@Adrastopoulos Adrastopoulos commented Nov 3, 2026

Copy link
Copy Markdown

Fixes #756

The AMQP reader now accepts attributes in application-properties with either the cloudEvents: or the cloudEvents_ prefix, as the AMQP binding (section 3.1.3.1) allows. ProtonAmqpMessageFactory.createReader finds the spec version under either prefix, and ProtonAmqpBinaryMessageReader reads attributes and extensions with either prefix. The writer is unchanged and still writes cloudEvents:.

ProtonAmqpMessageFactoryTest.readBinaryWithUnderscorePrefix reads every binary test case with the cloudEvents_ prefix. With the previous reader, all 10 cases fail with Could not parse. Unknown encoding. Invalid content type or spec version. All AMQP module tests pass, and a full ./mvnw verify shows no failures that main does not also have.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Adrastopoulos
fix(amqp): read cloudEvents_ application properties
ac4c843 
The AMQP binding allows the "cloudEvents_" prefix as well as
"cloudEvents:" (section 3.1.3.1), and says consumers should understand
both. JMS 2.0 clients can only use "cloudEvents_". The reader now accepts
either prefix. The writer still uses "cloudEvents:".

Fixes cloudevents#756

Signed-off-by: Gabriel Hall <[email protected]>
@yangjj-iso yangjj-iso mentioned this pull request Nov 6, 2026
AMQP Data payload ignores Binary offset and length #760
Open

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AMQP reader ignores application properties with the cloudEvents_ prefix

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@Adrastopoulos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.