GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: prefix AMQP extension application properties by yangjj-iso · Pull Request #767 · cloudevents/sdk-java

Conversation

@yangjj-iso

@yangjj-iso yangjj-iso commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Fixes #766.

Binary AMQP messages currently serialize extensions as bare application-property names, while the reader only accepts cloudEvents:-prefixed names. For example, a traceparent or custom extension disappears after a writer/Proton encode/decode/reader round trip.

Prefix the fallback extension names in ProtonAmqpMessageWriter, as required by the AMQP binding's primary mapping. Correct the existing writer expectations and add real wire round-trip coverage for CloudEvents 0.3 and 1.0, including traceparent, tracestate, and a custom extension. The tests use no payload to isolate this change from #761.

Validation:

  • Before the fix: 4 of 20 writer tests failed, including both new round trips.
  • After the fix: MAVEN_OPTS=-Xmx384m ./mvnw -B -ntp -pl amqp -am verify -Dmaxmemory=256m passed with 136 tests (API 8, core 90, AMQP 38), plus all three modules' Javadocs.
  • git diff --check passed. No live broker or full-repository integration suite was run.

AI assistance was used to investigate, implement, and test this change.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@yangjj-iso @duglin
fix: prefix AMQP extension application properties
0bbb6ef
Preserve extensions through binary AMQP encode/decode for both supported
CloudEvents versions and correct the existing writer expectations.

Fixes cloudevents#766

Signed-off-by: redyyang <[email protected]>
@duglin
duglin force-pushed the fix-amqp-extension-prefix branch from a1e7a03 to 0bbb6ef Compare November 12, 2026 16:31

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AMQP binary writer drops extension attributes during a round trip

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@yangjj-iso
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.