GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — fix(destination): quote PRAGMA table_info arguments in duckdb and sqlite by Tyagiquamar · Pull Request #23707 · cloudquery/cloudquery ConversationSummaryThe DuckDB and SQLite destinations built their Root causeThe table name comes from the source plugin's schema and is not escaped before it is placed inside the single-quoted literal. SQLite does not accept bound parameters in Fix
Test plan
Fixes #23171
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsBoth destinations interpolated the table name into a quoted string literal, so a table name containing a single quote either broke the statement or let arbitrary SQL run. Render the name as a proper string literal by doubling embedded quotes; SQLite does not accept bound parameters in PRAGMA statements. This branch has not been deployedNo deployments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersAt least 1 approving review is required to merge this pull request. Uh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabelsProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. plugins/destination/duckdb + sqlite: SQL injection in PRAGMA table_info queriesUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |