GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix bug in cloud client missing the project id and refactor the package by elivlo · Pull Request #7 · cloudstack/cloudstack-csi-driver

Conversation

@elivlo

@elivlo elivlo commented Apr 2, 2026

Copy link
Copy Markdown

Description of changes:
The client only uses the project ID in the function GetVMByID and not in the function getVMByName. This causes the CSI where the instance ID is not found in the metadata and the VM is in a project to fail. Eventually they fall back into a crash loop back off and the CSI is not usable.

It refactors all functions of the cloud package to use the default project_id option. This reduces code duplication by using cloudstack client methods that support the default options. This refactoring is based on the following fix: It fixes the function getVMByName by using the method GetVirtualMachineByName instead of ListVirtualMachines.

These changes ensure that the project id is automatically included and makes the code more mature.

Testing performed:
I installed k8s into Cloudstack inside of a project and without. The setup of the CSI worked when running in the root project but not in sub projects with the current version 3.0.0. I am using my PR version currently in a cluster on a Cloudstack instance within a project and with that it is working just fine.

Please create a bugfix release when the PR is approved and merged.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@artem-sidorenko

artem-sidorenko commented Jun 17, 2026

Copy link
Copy Markdown

@Pearl1594 any chance to get a review on this one?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tromob tromob mentioned this pull request Jul 16, 2026
[cloudstack-csi-driver] PVC resize stuck for project-owned volumes: ExpandVolume omits projectid (Count:0) apache/cloudstack#13634
Open
@tromob

tromob commented Jul 16, 2026

Copy link
Copy Markdown

This PR would also fix volume resize for project-owned volumes — reported in apache/cloudstack#13634.

On v3.0.0 / 3.0.1 / main, ExpandVolume in pkg/cloud/volumes.go uses the raw SDK call c.Volume.GetVolumeByID(volumeID) without projectid, so a project-scoped key gets Count:0 and ControllerExpandVolume fails forever (PVC stuck in Resizing). The global csClient.DefaultOptions(cloudstack.WithProject(config.ProjectID)) added here would cover that path too. Could the scope note be extended to mention volume resize, and ExpandVolume additionally skip the call when currentSize >= newSize? Tested on CloudStack 4.22 + Kubernetes v1.33.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Pearl1594
Pearl1594 reviewed Jul 16, 2026
View reviewed changes
Comment thread pkg/cloud/cloud.go Resolved

Uh oh!

There was an error while loading. Please reload this page.
Pearl1594
Pearl1594 approved these changes Jul 16, 2026
View reviewed changes

@Pearl1594 Pearl1594 left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Pearl1594 Pearl1594 mentioned this pull request Jul 16, 2026
Fix getVMByName to include projectID parameter #6
Closed
@elivlo
elivlo force-pushed the refactor-cloud-client branch from 3c7ce06 to c1cc366 Compare July 16, 2026 19:12
elivlo added 7 commits July 16, 2026 21:15
@elivlo
fix: use project id when getting VM by name
3e63e0b
@elivlo
refactor: remove global projectID from cloudstack client
5e59244
@elivlo
refactor: require arguments in snapshot functions
df2d65d
@elivlo
refactor: use project id default in cloudstack methods
f767406
@elivlo
docs: update default project id option description
a8b3414
@elivlo
fix: restore count checks in vms, volumes, snapshots
99cbc70
@elivlo
fix: add ttl for syncer job to allow helm upgrade
1b9cbaa
@elivlo
elivlo force-pushed the refactor-cloud-client branch from c1cc366 to 1b9cbaa Compare July 16, 2026 19:15
@elivlo

elivlo commented Jul 16, 2026

Copy link
Copy Markdown
Author

@Pearl1594 I have fixed the comment and rebased my branch on the main branch. It is now ready to merge. Should I also update the helm appVersion or will you do that?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@elivlo
elivlo requested a review from Pearl1594 July 16, 2026 19:18
@elivlo

elivlo commented Jul 31, 2026

Copy link
Copy Markdown
Author

@Pearl1594 Could you please have a look into this PR again and create a release if the changes are fine?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@elivlo

elivlo commented Aug 5, 2026

Copy link
Copy Markdown
Author

@tromob I guess that we have to rely on our own private forks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@C0rn3rphr34k

C0rn3rphr34k commented Aug 21, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Just stumbled upon this Issue and MR due to me trying to get a Talos Linux Kubernetes cluster working with cloudstack-csi-driver.
Thank you for the hard work and looking forward to the new release, so I don't have to run the clusters outside of projects.
Happy to test changes if necessary
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Pearl1594
Pearl1594 reviewed Aug 25, 2026
View reviewed changes

@Pearl1594 Pearl1594 left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code overall lgtm. left some comments for cleanup.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
elivlo reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread pkg/cloud/volumes.go Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread pkg/cloud/cloud.go Resolved

Uh oh!

There was an error while loading. Please reload this page.
@elivlo
refactor: remove dead code in cloud package
27b4357
@elivlo

elivlo commented Aug 26, 2026

Copy link
Copy Markdown
Author

@Pearl1594 Thanks for the review. I guess the PR is ready? If not, please let me know :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Pearl1594

Pearl1594 commented Aug 26, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

It is ready - but will do some internal testing before we proceed with merging. Thank you for the PR and sorry for the delay.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@elivlo

elivlo commented Aug 27, 2026

Copy link
Copy Markdown
Author

Thanks! I am looking forward to switch back my fork to the official CSI :)
Pearl1594 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Pearl1594

Pearl1594 commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Tested the PR:
Created a project as a regular user and created a CKS cluster with CSI enabled. Once the cluster was deployed, I updated the manifest file at /opt/csi/manifest.yaml with a locally built image based off this PR (merged with the go sdk upgrade to 2.19.1)

kubectl describe po cloudstack-csi-controller-66b5cb656b-7f9dq -n kube-system | grep Image
    Image:           pearl1594/cloudstack-csi-driver:sdk-proj
    Image ID:        docker.io/pearl1594/cloudstack-csi-driver@sha256:1609934ec3a0b5e84b3770b7dbdbb7c6d3a6899a804a6cd1485c1c58b2d91d5c

# kubectl describe po cloudstack-csi-node-8s6zk -n kube-system | grep Image
    Image:         pearl1594/cloudstack-csi-driver:sdk-proj
    Image ID:      docker.io/pearl1594/cloudstack-csi-driver@sha256:1609934ec3a0b5e84b3770b7dbdbb7c6d3a6899a804a6cd1485c1c58b2d91d5c

Proceeded to then create a storage class, pvc and pod - successfully created in the project:

# kubectl get po -A
NAMESPACE              NAME                                                           READY   STATUS    RESTARTS   AGE
default                example-pod                                                    1/1     Running   0          32s
kube-system            calico-kube-controllers-7bfdc5b57c-p5qzg                       1/1     Running   0          19m
kube-system            calico-node-cgx6j                                              1/1     Running   0          19m
kube-system            calico-node-jl44v                                              1/1     Running   0          19m
kube-system            cloud-controller-manager-857cd68cf5-tssgs                      1/1     Running   0          19m
kube-system            cloudstack-csi-controller-66b5cb656b-7f9dq                     7/7     Running   0          6m9s
kube-system            cloudstack-csi-controller-66b5cb656b-p42r9                     7/7     Running   0          6m28s
kube-system            cloudstack-csi-node-8s6zk                                      3/3     Running   0          6m26s
kube-system            cloudstack-csi-node-cffdq                                      3/3     Running   0          6m14s
kube-system            coredns-674b8bbfcf-pgbbr                                       1/1     Running   0          19m
kube-system            coredns-674b8bbfcf-xw4tk                                       1/1     Running   0          19m
kube-system            etcd-k8s-proj-cks-csi-control-1a05e6cb7ad                      1/1     Running   0          19m
kube-system            kube-apiserver-k8s-proj-cks-csi-control-1a05e6cb7ad            1/1     Running   0          19m
kube-system            kube-controller-manager-k8s-proj-cks-csi-control-1a05e6cb7ad   1/1     Running   0          19m
kube-system            kube-proxy-6jc76                                               1/1     Running   0          19m
kube-system            kube-proxy-dw5jq                                               1/1     Running   0          19m
kube-system            kube-scheduler-k8s-proj-cks-csi-control-1a05e6cb7ad            1/1     Running   0          19m
kubernetes-dashboard   dashboard-metrics-scraper-5bd45c9dd6-v74dg                     1/1     Running   0          19m
kubernetes-dashboard   kubernetes-dashboard-687457b9bd-bt6lp                          1/1     Running   0          19m

Logs indicating that it identified the project context:

# kubectl -n kube-system logs -f deployment/cloudstack-csi-controller | grep -i project
Found 2 pods, using pod/cloudstack-csi-controller-66b5cb656b-p42r9
Defaulted container "cloudstack-csi-controller" out of: cloudstack-csi-controller, external-provisioner, external-attacher, external-resizer, csi-snapshotter, snapshot-controller, liveness-probe
I0901 19:39:34.684069       1 cloud.go:114] "Set projectID to cloud connector" projectID="8d85ce7f-4aff-4c48-bd2e-f3b0480ba1e6"
image

SNAPSHOT:
Wrote some data into the example pod:
kubectl exec example-pod -- sh -c 'echo "hello from before snapshot" > /data/test.txt'

# kubectl exec example-pod -- cat /data/test.txt
hello from before snapshot

Created a snapshot using the config /maniest in the examples: kubectl apply -f snapshot/snapshot.yaml

# kubectl get volumesnapshot snapshot-1 -w
NAME         READYTOUSE   SOURCEPVC     SOURCESNAPSHOTCONTENT   RESTORESIZE   SNAPSHOTCLASS         SNAPSHOTCONTENT                                    CREATIONTIME   AGE
snapshot-1   true         example-pvc                           0             cloudstack-snapshot   snapcontent-80603353-2fef-4983-85f1-74921db8dbcc   8m10s          8m10s

Snapshot created in CloudStack project:
image

RESTORED SNAPSHOT INTO A NEW PVC:

# kubectl apply -f snapshot/pvc-from-snapshot.yaml
persistentvolumeclaim/pvc-from-snapshot created

# kubectl get pvc pvc-from-snapshot -w
NAME                STATUS    VOLUME   CAPACITY   ACCESS MODES   STORAGECLASS        VOLUMEATTRIBUTESCLASS   AGE
pvc-from-snapshot   Pending                                      cloudstack-custom   <unset>                 15s

MOUNT INTO A POD AND VERIFY IF DATA SURVIVED:

kubectl apply -f snapshot/restore-pod.yaml

Restored pod has the data of the snapshot:

# kubectl exec restore-pod -- cat /data/test.txt
hello from before snapshot

Restored vol / PV:
image

RESIZE TEST:

Patched storage class to have allowVolumeExpansion to true:
Before patch:

# kubectl get sc cloudstack-custom -o yaml | grep allowVolumeExpansion
allowVolumeExpansion: false

After patch:

# kubectl patch sc cloudstack-custom -p '{"allowVolumeExpansion": true}'
storageclass.storage.k8s.io/cloudstack-custom patched

root@k8s-proj-cks-csi-control-1a05e6cb7ad:~/cloudstack-csi-driver/examples/k8s# kubectl get sc cloudstack-custom -o yaml | grep allowVolumeExpansion
allowVolumeExpansion: true

Perform resize:

# kubectl get pvc example-pvc -o jsonpath='{.spec.resources.requests.storage}{"\n"}'
1Gi

# kubectl get pvc example-pvc -w
NAME          STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS        VOLUMEATTRIBUTESCLASS   AGE
example-pvc   Bound    pvc-ee9c5049-ec2d-41cb-90e2-9fa1441994c7   2Gi        RWO            cloudstack-custom   <unset>                 23m

Successfully resized the vol in ACS (proj):
<img width="1857" height="783" alt="image" src="https://github.com/user-attachments/assets/f5fdbab5-c005-4397-98e0-8ce026d202db" />
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Pearl1594
Pearl1594 merged commit a84477e into cloudstack:main Sep 1, 2026
3 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@elivlo

elivlo commented Sep 22, 2026

Copy link
Copy Markdown
Author

@Pearl1594 Could you please also create a release and reference it in helm so we don't have to use container image with latest tag?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Pearl1594

Pearl1594 commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator

I can do that sometime the following week. I would appreciate your review on: #8 - so we could include that as well in the release. Thanks @elivlo .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pearl1594 Pearl1594 Pearl1594 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@elivlo @artem-sidorenko @tromob @C0rn3rphr34k @Pearl1594
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.