GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — CC0122 Replace Task.Result with await Task by AmadeusW · Pull Request #820 · code-cracker/code-cracker

Conversation

@AmadeusW

@AmadeusW AmadeusW commented Aug 12, 2016

Copy link
Copy Markdown

Fixes #734
Supersedes #805
CC0122 Replace Task.Result with await Task

Adds Design Warning CC0122 when System.Threading.Tasks.Task<TResult>.Result is used in async method.
The code fix provider replaces .Result with async

Screenshot of a non trivial case:
cc0122

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AmadeusW
CC0122 Replace Task.Result with await Task
9fea23d
@AmadeusW AmadeusW mentioned this pull request Aug 12, 2016
CC0122 Replace Task.Result with await Task #805
Closed
@coveralls

coveralls commented Aug 12, 2016

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.07%) to 91.552% when pulling 9fea23d on AmadeusW:resultInAsync into 794c05a on code-cracker:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@giggio giggio self-assigned this Aug 14, 2016
@giggio giggio added the 2 - Working label Aug 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@giggio giggio

Labels

2 - Working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace Task.Result with await Task

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@AmadeusW @coveralls @giggio
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.