GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Suffix Array by Ankitr19 · Pull Request #243 · codeIIEST/Algorithms

Conversation

@Ankitr19

@Ankitr19 Ankitr19 commented Dec 18, 2017

Copy link
Copy Markdown
Contributor

Thank you for your contribution. Please provide the details requested below.

ISSUE NUMBER

Please provide a link to the issue this pull request addresses.

SHORT DESCRIPTION

I have added the Suffix Array code to the string folder.

TESTING

To test the code simply provide any string in the main function of the code, and the code will generate the suffix array for the string.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Ankitr19 added 2 commits December 18, 2017 22:53
@Ankitr19
Suffix Array
1eb6038
@Ankitr19
Update Suffix_Array.cpp
dd3b439
@prateekiiest prateekiiest added kwoc tests failing labels Dec 28, 2017
@prateekiiest

prateekiiest commented Dec 28, 2017

Copy link
Copy Markdown
Member

you need to fix the tests first
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Ankitr19 added 4 commits December 28, 2017 15:13
@Ankitr19
Update Suffix_Array.cpp
5c4fe0d 
Memory leak rectified.
@Ankitr19
Update Suffix_Array.cpp
b8f7184 
Updated
@Ankitr19
Update Suffix_Array.cpp
d96682d
@Ankitr19
Update Suffix_Array.cpp
e376f12
@Ankitr19

Ankitr19 commented Dec 28, 2017

Copy link
Copy Markdown
Contributor Author

@prateekiiest I have fixed the issue.
prateekiiest reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
prateekiiest
prateekiiest reviewed Dec 28, 2017
View reviewed changes

@prateekiiest prateekiiest left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few fixes to be made.

Otherwise it looks good ㊗️ 🎆

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Competitive Coding/Strings/String Search/SuffixArray/Suffix_Array.md
Application of suffix array:-

Suffix array is an extremely useful data structure, it can be used for a wide range of problems. Following are some famous problems where Suffix array can be used.
1) Pattern Searching

@prateekiiest prateekiiest Dec 28, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use * instead of numbering

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Competitive Coding/Strings/String Search/SuffixArray/Suffix_Array.md

The suffixes are:-

0 banana 5 a

@prateekiiest prateekiiest Dec 28, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this part more look good.

Like codify this part to make it look good. Otherwise this part looks odd

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Competitive Coding/Strings/String Search/SuffixArray/Suffix_Array.cpp
map<string,int> m;

vector<string> v;
for(int i = 0; i < s.size();i++)

@prateekiiest prateekiiest Dec 28, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments here will make it better

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@prateekiiest prateekiiest added changes requested and removed tests failing labels Dec 31, 2017

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prateekiiest prateekiiest prateekiiest left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

changes requested kwoc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Ankitr19 @prateekiiest
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.