GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — v2.1.0 by Bhupesh-V · Pull Request #34 · codeclassroom/codeclassroom

Conversation

@Bhupesh-V

@Bhupesh-V Bhupesh-V commented Jan 22, 2020

Copy link
Copy Markdown
Contributor

v2.1.0

Added

  • Custom Input can now be provided for judging programs.
  • E-mail API.
  • Swagger Docs at /api.
  • Token Authentication.

Removed

  • Old documentation end-point /api-docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Bhupesh-V added 6 commits January 19, 2020 20:13
@Bhupesh-V
possible fix #19
edbf857
- Custom Input can now be provided for judging programs.
- Wrote JudgeSerializer
- minor adjustments
@Bhupesh-V
Email API
69fec29
- Possibe Fix #10
- API for Website Feedback
@Bhupesh-V
minor changes
e8120e3
@Bhupesh-V
possible fix #16
d7a96db
@Bhupesh-V
new stuff
dd24211
- official API Docs at /api
- wrote PlagiarismSerializer
- update dependencies
- Add Token Auth
- removed old docs
- remove requires.io badge
- improved email api
@Bhupesh-V
Contributing guidelines update
c824621
@pep8speaks

pep8speaks commented Jan 22, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Hello @Bhupesh-V! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

  • In the file api/urls.py:

Line 20:80: E501 line too long (96 > 79 characters)
Line 37:80: E501 line too long (88 > 79 characters)
Line 76:80: E501 line too long (89 > 79 characters)

  • In the file api/views.py:

Line 232:80: E501 line too long (82 > 79 characters)
Line 324:80: E501 line too long (87 > 79 characters)

  • In the file utilities/judge.py:

Line 18:80: E501 line too long (83 > 79 characters)

Comment last updated at 2020-01-22 08:07:00 UTC
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost

ghost commented Jan 22, 2020 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

DeepCode's analysis on #cb5025 found:

  • ❌ 0 critical issues. ⚠️ 0 warnings and 1 minor issue. ✔️ 2 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

Bhupesh-V reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@codecov

codecov Bot commented Jan 22, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Merging #34 into master will decrease coverage by 3.6%.
The diff coverage is 49.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
- Coverage    65.8%   62.19%   -3.61%     
==========================================
  Files          20       21       +1     
  Lines         500      619     +119     
==========================================
+ Hits          329      385      +56     
- Misses        171      234      +63
Impacted Files Coverage Δ
app/urls.py 100% <ø> (ø) ⬆️
codeclassroom/urls.py 88.88% <ø> (ø) ⬆️
api/urls.py 100% <100%> (ø) ⬆️
app/serializers.py 90.62% <100%> (+2.31%) ⬆️
utilities/codesim.py 29.41% <100%> (ø) ⬆️
utilities/email.py 18.91% <18.91%> (ø)
utilities/judge.py 14.81% <22.22%> (-1.19%) ⬇️
codeclassroom/settings.py 82.85% <45.45%> (-17.15%) ⬇️
api/views.py 55.67% <50%> (-3.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e31e6ca...cb50259. Read the comment docs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@lgtm-com

lgtm-com Bot commented Jan 22, 2020

Copy link
Copy Markdown

This pull request introduces 1 alert and fixes 1 when merging c824621 into e31e6ca - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 1 for Unused import
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Bhupesh-V
improve code
cb50259
- update FROM_EMAIL
- linting fixes
@Bhupesh-V
Bhupesh-V merged commit e412315 into master Jan 22, 2020
@Bhupesh-V
Bhupesh-V deleted the dev branch January 22, 2020 08:10
@lgtm-com

lgtm-com Bot commented Jan 22, 2020

Copy link
Copy Markdown

This pull request fixes 1 alert when merging cb50259 into e31e6ca - view on LGTM.com

fixed alerts:

  • 1 for Unused import
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Bhupesh-V @pep8speaks
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.