GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Upgrade to 8.30 by wfleming · Pull Request #26 · codeclimate/codeclimate-checkstyle

Conversation

@wfleming

@wfleming wfleming commented Mar 5, 2020

Copy link
Copy Markdown
Contributor

Tweaked Makefile to run container as root for these tasks so it can
overwrite the mounted files.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@wfleming
wfleming force-pushed the will/upgrade-8-30 branch 2 times, most recently from 86b3c03 to 745d96d Compare March 5, 2020 22:43
@wfleming
Upgrade to 8.30
157cf25 
Tweaked Makefile to run container as root for these tasks so it can
overwrite the mounted files.
@wfleming
wfleming force-pushed the will/upgrade-8-30 branch from 745d96d to 157cf25 Compare March 5, 2020 22:44
@wfleming

wfleming commented Mar 5, 2020

Copy link
Copy Markdown
Contributor Author

Looks like the config xml needs to be updated
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@wfleming
Update config for JavadocMethodo
0eec17a 
https://checkstyle.org/config_javadoc.html#JavadocMethod

Available properties here seem to have changed: `validateThrows` seems
to be the replacement for the two other throws-related properties that
were previously here.
@wfleming
wfleming requested a review from filipesperandio March 6, 2020 16:03
filipesperandio
filipesperandio approved these changes Mar 6, 2020
View reviewed changes
@wfleming
wfleming merged commit f9c3383 into master Mar 6, 2020
@wfleming
wfleming deleted the will/upgrade-8-30 branch March 6, 2020 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@filipesperandio filipesperandio filipesperandio approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@wfleming @filipesperandio
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.