GeezerVison is showing github.com — Fix Typescript extension not loading · coder/code-server@c074fa8
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: CHANGELOG.md +5Lines changed: 5 additions & 0 deletions - Display the source diff
- Display the rich diff
| Original file line number | Diff line number | Diff line change |
|---|
@@ -30,6 +30,11 @@ Code v1.141.0 |
30 | 30 | workbench storage on the remote server instead of browser storage. Use this if |
31 | 31 | you want to share storage between multiple devices. |
32 | 32 |
|
| 33 | +### Fixed |
| 34 | + |
| 35 | +- The Typescript extension was trying to load as a browser extension even though |
| 36 | + we build the remote server version, causing it to fail to activate. |
| 37 | + |
33 | 38 | ### Changed |
34 | 39 |
|
35 | 40 | - Update to Code 1.141.0 |
|
Collapse file
Copy file name to clipboardExpand all lines: ci/build/build-vscode.sh +14-4Lines changed: 14 additions & 4 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -58,10 +58,17 @@ main() { |
58 | 58 | exit 1 |
59 | 59 | fi |
60 | 60 |
|
61 | | - # Add the date, our name, links, enable telemetry (this just makes telemetry |
62 | | - # available; telemetry can still be disabled by flag or setting), and |
63 | | - # configure trusted extensions (since some, like github.copilot-chat, never |
64 | | - # ask to be trusted and this is the only way to get auth working). |
| 61 | + # Modify the product.json: |
| 62 | + # - Add the date |
| 63 | + # - Set the code-server name. |
| 64 | + # - Add our links |
| 65 | + # - Enable telemetry (this just makes telemetry available; telemetry can still |
| 66 | + # be disabled by flag or setting) |
| 67 | + # - Configure trusted extensions (since some, like github.copilot-chat, never |
| 68 | + # ask to be trusted and this is the only way to get auth working). |
| 69 | + # - Make Typescript server plugins run in the workspace. We build the remote |
| 70 | + # server version, so there is no browser distribution, and this key is not |
| 71 | + # added automatically. |
65 | 72 | # |
66 | 73 | # This needs to be done before building as Code will read this file and embed |
67 | 74 | # it into the client-side code. |
@@ -103,6 +110,9 @@ main() { |
103 | 110 | ], |
104 | 111 | "aiConfig": { |
105 | 112 | "ariaKey": "code-server" |
| 113 | + }, |
| 114 | + "extensionPointExtensionKind": { |
| 115 | + "typescriptServerPlugins": ["workspace"] |
106 | 116 | } |
107 | 117 | } |
108 | 118 | EOF |
|
Collapse file
Copy file name to clipboard +10Lines changed: 10 additions & 0 deletions | Original file line number | Diff line number | Diff line change |
|---|
|
| 1 | +import { describe, test } from "./baseFixture" |
| 2 | + |
| 3 | +const args = ["--disable-workspace-trust"] |
| 4 | + |
| 5 | +describe("typescript extension", args, {}, () => { |
| 6 | + test("should load as a workspace extension", async ({ codeServerPage }) => { |
| 7 | + await codeServerPage.executeCommandViaMenus("Developer: Show Running Extensions") |
| 8 | + await codeServerPage.page.waitForSelector('[aria-label="typescript-language-features"] >> text=localhost:') |
| 9 | + }) |
| 10 | +}) |