GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add Vietnamese locale by dinhkarate · Pull Request #8107 · coder/code-server

Conversation

@dinhkarate

@dinhkarate dinhkarate commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Adds a Vietnamese (vi) translation of the login page strings.

  • New src/node/i18n/locales/vi.json with all 11 keys from en.json; the {{app}}, $PASSWORD and $HASHED_PASSWORD placeholders are kept unchanged.
  • Registers vi in defaultResources in src/node/i18n/index.ts, following the Turkish locale (feat(i18n): add Turkish login locale #8050).

No test was added. The per-language test that came with #8050 was later removed in #8069, so this PR follows the current state of test/unit/node/i18n.test.ts.

Checks run: vi.json parses as JSON, its keys match en.json (same order), placeholders match for every entry, and prettier --check passes on both changed files.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dinhkarate
Add Vietnamese locale
e49727e
@dinhkarate
dinhkarate requested a review from a team as a code owner November 3, 2026 17:09
code-asher
code-asher approved these changes Nov 3, 2026
View reviewed changes
@code-asher

code-asher commented Nov 3, 2026

Copy link
Copy Markdown
Member

Thank you!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@code-asher
code-asher enabled auto-merge (squash) November 3, 2026 20:28
@code-asher
code-asher merged commit c587540 into coder:main Nov 3, 2026
10 checks passed

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@code-asher code-asher code-asher approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@dinhkarate @code-asher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.