GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — refactor: migrate TermsOfServiceLink from MUI to shadcn/ui by jaaydenh · Pull Request #20260 · coder/coder

Conversation

@jaaydenh

@jaaydenh jaaydenh commented Oct 12, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Summary

Migrate the TermsOfServiceLink component from MUI to shadcn/ui

Changes

  • Replaced @mui/material/Link with the custom Link component from components/Link/Link (shadcn/ui)
  • Migrated Emotion css prop to Tailwind utility classes
  • Preserved external link icon functionality (automatically provided by shadcn Link component)

🤖 Generated with Claude Code

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jaaydenh @claude
refactor: migrate TermsOfServiceLink from MUI to shadcn/ui
8e64846 
Replace MUI Link with custom Link component from shadcn/ui and migrate
Emotion CSS to Tailwind utility classes. This is part of the ongoing
effort to standardize on shadcn/ui components and Tailwind CSS.

Changes:
- Replace @mui/material/Link with components/Link/Link
- Remove Emotion css prop in favor of Tailwind classes
- Maintain visual consistency with pt-3, text-base, font-medium
- Keep external link icon from shadcn Link component
- No functional changes to component behavior

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@jaaydenh
jaaydenh requested review from aslilac and buenos-nachos as code owners October 12, 2025 14:00
@github-actions github-actions Bot assigned jaaydenh Oct 12, 2025
@jaaydenh
chore: cleanup
ca88d0c
@jaaydenh jaaydenh mentioned this pull request Oct 12, 2025
refactor: migrate CopyableValue from MUI to Radix UI #20261
Merged
aslilac
aslilac reviewed Oct 14, 2025
View reviewed changes
Comment thread site/src/pages/LoginPage/TermsOfServiceLink.tsx Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread site/src/pages/LoginPage/TermsOfServiceLink.tsx
rel="noreferrer"
>
Terms of Service&nbsp;
<SquareArrowOutUpRightIcon className="size-icon-xs" />

@aslilac aslilac Oct 14, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why get rid of the arrow? it's to indicate it'll open in a new tab

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@jaaydenh jaaydenh Oct 15, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The component already has SquareArrowOutUpRightIcon inside it

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
aslilac
aslilac approved these changes Oct 14, 2025
View reviewed changes

@aslilac aslilac left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I didn't realize the icon would come from the new component

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jaaydenh
chore: cleanup
e86baad
@jaaydenh
jaaydenh merged commit 3699ff6 into main Oct 15, 2025
3 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@jaaydenh
jaaydenh deleted the jaaydenh/refactor-terms-of-service branch October 15, 2025 11:16
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aslilac aslilac aslilac approved these changes
@buenos-nachos buenos-nachos Awaiting requested review from buenos-nachos

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@jaaydenh jaaydenh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jaaydenh @aslilac
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.