GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(site): add icons for .sh, .json, and .y[a]ml files in template editor by matifali · Pull Request #21171 · coder/coder

Conversation

@matifali

@matifali matifali commented Dec 8, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Added specific icons for common file types in the template file tree:

  • .sh files: TerminalIcon (terminal/shell scripts)
  • .json files: BracesIcon (JSON data files)
  • .yaml/.yml files: FileCodeIcon (YAML configuration files)
image

These icons help users quickly identify file types at a glance in the template editor.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-actions github-actions Bot assigned matifali Dec 8, 2025
@matifali
feat(site): add icons for .sh, .json, and .yaml files in template editor
c0cd338 
Added specific icons for common file types in the template file tree:
- .sh files: TerminalIcon (terminal/shell scripts)
- .json files: BracesIcon (JSON data files)
- .yaml/.yml files: FileCodeIcon (YAML configuration files)

These icons help users quickly identify file types at a glance.
@matifali
matifali force-pushed the fix-rename-dialog-state branch from eeb5a97 to c0cd338 Compare December 8, 2025 19:00
@matifali matifali changed the title fix(site): sync RenameFileDialog state when filename prop changes feat(site): add icons for .sh, .json, and .yaml files in template editor Dec 8, 2025
@matifali
matifali requested a review from Copilot December 8, 2025 19:01
Copilot started reviewing on behalf of matifali December 8, 2025 19:02
View session
Copilot AI reviewed Dec 8, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the template file tree UI by adding distinctive icons for three common file types (.sh, .json, .yaml/.yml) that previously had no specific visual representation. The implementation uses lucide-react icons (TerminalIcon, BracesIcon, FileCodeIcon) following the existing conditional logic pattern based on file extensions.

Key Changes:

  • Added file type detection for .sh, .json, and .yaml/.yml files
  • Imported three new icons from lucide-react library
  • Extended icon assignment logic in the buildTreeItems function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@matifali
docs(storybook): update example story to showcase new file type icons
4dfbbfe 
Updated the main example story to include files with the new icons:
- Shell scripts (.sh) - terminal icon
- JSON files (.json) - braces icon
- YAML files (.yml) - file code icon
- Markdown (.md) and Dockerfile icons

This shows all icon types in a single realistic file tree example.
@matifali
matifali force-pushed the fix-rename-dialog-state branch from 333f052 to 4dfbbfe Compare December 8, 2025 19:22
geokat
geokat reviewed Dec 8, 2025
View reviewed changes
Comment thread site/src/modules/templates/TemplateFiles/TemplateFileTree.stories.tsx Resolved

Uh oh!

There was an error while loading. Please reload this page.
@matifali
matifali requested a review from phorcys420 December 9, 2025 16:00
@matifali
Merge branch 'main' into fix-rename-dialog-state
3e20906
@matifali matifali changed the title feat(site): add icons for .sh, .json, and .yaml files in template editor feat(site): add icons for .sh, .json, and .y[a]ml files in template editor Dec 10, 2025
@matifali
fmt
f1ea6b3
phorcys420
phorcys420 approved these changes Dec 10, 2025
View reviewed changes
@phorcys420
phorcys420 merged commit ed3bb76 into main Dec 10, 2025
24 of 26 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@phorcys420
phorcys420 deleted the fix-rename-dialog-state branch December 10, 2025 20:19
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@geokat geokat geokat left review comments
Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@phorcys420 phorcys420 phorcys420 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@matifali matifali

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@matifali @geokat @phorcys420
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.