GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore: update Go from 1.25.7 to 1.26.1 by blinkagent[bot] · Pull Request #22262 · coder/coder

Conversation

@blinkagent

@blinkagent blinkagent Bot commented Feb 23, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Update Go from 1.25.7 to 1.26.1.

Release notes: https://go.dev/blog/go1.26

Created on behalf of @kylecarbs

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@blink-so
chore: update Go from 1.25.7 to 1.26.0
62288dc
@blinkagent
blinkagent Bot requested a review from jdomeracki-coder as a code owner February 23, 2026 15:02
blink-so Bot added 2 commits February 23, 2026 15:08
@blink-so
fix: revert flake.nix changes and update generated api docs
0234a3a
@blink-so
fix: update flake.nix and flake.lock for Go 1.26
245aa8b
@blinkagent
blinkagent Bot force-pushed the kyle/go126 branch from 8c5d06f to 245aa8b Compare February 23, 2026 15:33
@johnstcn johnstcn assigned johnstcn and kylecarbs and unassigned johnstcn Feb 25, 2026
@johnstcn
johnstcn self-requested a review February 25, 2026 14:43
@johnstcn

johnstcn commented Feb 25, 2026

Copy link
Copy Markdown
Member

Something is very wrong with Windows on this.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@blinkagent

blinkagent Bot commented Feb 25, 2026

Copy link
Copy Markdown
Contributor Author

I've been investigating this. Here's a summary:

What's happening

The Windows test binary is hitting Go's default 10-minute per-package timeout. All failures show (unknown) status — no test actually fails an assertion, they're just killed mid-execution. The goroutine dumps in the logs confirm this: goroutines are stuck in normal operations (selectgo, IO wait, sync.WaitGroup.Wait) when the timeout fires.

Run 1: DONE 2010 tests, 72 skipped, 781 failures in 56.673s (cold cache)
Run 2: DONE 2096 tests, 81 skipped, 59 failures in 94.478s (warm cache, got further)

Root cause

Go 1.26 introduces the Green Tea GC as the default garbage collector. There are known Windows-specific issues:

  • golang/go#77567: High memory usage on Windows with Go 1.26 (Green Tea GC related)
  • golang/go#77407: os.RemoveAll regression on Windows (backported to Go 1.26.1)

The test suite runs heavyweight integration tests (HTTP servers, wireguard tunnels, embedded postgres) in parallel. The new GC appears to cause enough overhead on Windows to push the tests past their timeout.

Options

  1. GOEXPERIMENT=nogreenteagc — disable Green Tea GC at build time for the Windows test job to confirm this is the cause
  2. Increase Windows test timeout — add -timeout 20m to GOTEST_FLAGS (currently using Go's 10m default)
  3. Wait for Go 1.26.1 — which will include fixes for the Windows-specific issues
  4. Reduce Windows test parallelism — currently 8 packages × 16 tests = 128 concurrent tests
johnstcn reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

johnstcn added 2 commits February 25, 2026 16:14
@johnstcn
try disable green tea gc on windows runners
7b00db0
@johnstcn
Revert "try disable green tea gc on windows runners"
8f6a1e5
This reverts commit 7b00db0.
@github-actions github-actions Bot added the stale This issue is like stale bread. label Mar 5, 2026
@github-actions github-actions Bot closed this Mar 9, 2026
@johnstcn johnstcn removed the stale This issue is like stale bread. label Mar 24, 2026
@johnstcn johnstcn reopened this Mar 24, 2026
@johnstcn johnstcn mentioned this pull request Mar 24, 2026
chore: upgrade Go to 1.26 coder/terraform-provider-coder#494
Merged
johnstcn and others added 2 commits March 24, 2026 12:14
@johnstcn
Merge branch 'main' into kyle/go126
1f7c76f
@blink-so
chore: update Go from 1.26.0 to 1.26.1
afd83bb
@blinkagent blinkagent Bot changed the title chore: update Go from 1.25.7 to 1.26.0 chore: update Go from 1.25.7 to 1.26.1 Mar 24, 2026
@blinkagent

blinkagent Bot commented Mar 24, 2026

Copy link
Copy Markdown
Contributor Author

Windows CI Failure Investigation

The test-go-pg (windows-2022) job is failing with 621 out of 2386 tests marked as failures. This is caused by a known Go runtime bug affecting Go 1.26.0 and 1.26.1 on Windows — not related to any code changes in this PR.

Root Cause

The crash signature is:

fatal error: unexpected signal during runtime execution
panic during panic
[signal 0xc0000005 code=0x0 addr=0xe8 pc=0x7ff70ebdab05]

This is an ACCESS_VIOLATION in runtime.(*unwinder).next during runtime.scanstack → runtime.markroot (GC stack scanning). The underlying issue is in internal/poll on Windows: WSARecvFrom writes to the rsan (address length) parameter after overlapped I/O completes. When rsan is a local stack variable inside a closure, and the goroutine's stack is moved/shrunk between the syscall initiation and completion, Windows writes to the old (now-invalid) stack address, corrupting return addresses.

Notably, this is not caused by the Green Tea GC — GOEXPERIMENT=nogreenteagc still reproduces the crash.

Upstream Tracking

  • Original report: runtime: Windows crash with Go 1.26.0, 1.26.1 golang/go#77975 (closed, fixed)
  • 1.26 backport: runtime: Windows crash with Go 1.26.0, 1.26.1 [1.26 backport] golang/go#78041 (closed, cherry-picked)
  • Fix CL: https://go-review.googlesource.com/c/go/+/753040 — moves rsan from the goroutine stack to the heap
  • Fix target: Go 1.26.2 (not yet released)

Ubuntu CI Failure

The test-go-pg (ubuntu-latest) failure is unrelated — only 2 test failures out of 17,351 (TestRun/RPTY timeout), which appears to be a flaky test.

Recommendation

The Windows failure can be ignored until Go 1.26.2 is released with the fix. This PR should be safe to merge once rebased onto the latest main and the non-Windows checks pass.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

matifali added 2 commits March 27, 2026 17:15
@matifali
Merge branch 'main' into kyle/go126
fb86e67
@matifali
Merge branch 'main' into kyle/go126
7d3f867
@github-actions github-actions Bot added the stale This issue is like stale bread. label Apr 5, 2026
@github-actions github-actions Bot closed this Apr 8, 2026
@matifali matifali mentioned this pull request May 5, 2026
chore: bump Go toolchain version to 1.26.2 #24975
Merged
@github-actions
github-actions Bot deleted the kyle/go126 branch September 29, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdomeracki-coder jdomeracki-coder Awaiting requested review from jdomeracki-coder jdomeracki-coder is a code owner
@johnstcn johnstcn Awaiting requested review from johnstcn

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@kylecarbs kylecarbs

Labels

stale This issue is like stale bread.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@johnstcn @kylecarbs @matifali
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.