GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||
GeezerVison is showing github.com — fix(cli): exit coder ssh --stdio when stdin closes before connection by Tyagiquamar · Pull Request #28597 · coder/coder ConversationFixes #27954 ProblemOn Windows, Root causeIn stdio mode nothing reads stdin before FixRelay stdin through an TestingNew regression test fails on current main and passes with the fix: Additional verification run locally on windows/amd64, Go 1.26.5: Broader cli-package failures seen on this machine (TestRoot, TestGitSSH, TestDERPHeaders, TestCommandHelp, TestServer, TestWorkspaceAgent) were confirmed to reproduce identically on pristine main; for example TestRoot shells out to AI involvement: developed with AI assistance under human direction; the commands and results above were produced by running them locally, per the AI contribution guidelines.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsProxyCommand clients close stdin when they abandon a connection attempt. Nothing read stdin before the SSH session was established, so on Windows (no parent-death signal) abandoned processes leaked while waiting for the agent or dialing. Relay stdin through a pipe and cancel the command when it terminates pre-connection; existing copy logic still owns stdin termination once connected. Closes coder#27954 Signed-off-by: Tyagiquamar <[email protected]>
Tyagiquamar
marked this pull request as ready for review
|
There was an error while loading. Please reload this page.
|
All contributors have signed the CLA ✍️ ✅ |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I have read the CLA Document and I hereby sign the CLA |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
recheck |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
recheck |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
recheck |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I have read the CLA Document and I hereby sign the CLA |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
recheck |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Hi @DanielleMaywood, could you please review when you have a chance? Thanks! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
bug: Windows orphaned coder ssh --stdio processes after interrupted Codex connection retries
There was an error while loading. Please reload this page.