GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(site): share org in personal agent model settings by jakehwll · Pull Request #29122 · coder/coder

Conversation

@jakehwll

@jakehwll jakehwll commented Sep 9, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

🤖 This PR was modified by Coder Agents on behalf of Jake Howell.

Personal model overrides use the shared org search parameter and one mutation that saves and invalidates the selected organization. Saves are serialized across rows and organization switches, with organization-aware toast feedback.

Empty catalogs still allow resetting overrides to defaults. Background refetches preserve unsaved edits, and confirmed saves remain cached if the subsequent refresh fails. Behavior tests cover saves, retries, organization switches, and refetches; Storybook covers the visual states.

Frontend audit decisions
  • Kept shared ModelSelector styling unchanged to avoid affecting unrelated consumers.
  • Preserved default-mode recovery for organizations without selectable models.
  • Moved shared fixtures into testHelpers and behavioral assertions out of stories.
  • Retained existing shared slider accessibility and label-truncation behavior outside this PR’s scope.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
jakehwll added 3 commits September 9, 2026 07:49
@jakehwll
feat: refactor page logic
ff6de7e
@jakehwll
fix: override copy
d42a737
@jakehwll
fix: leftovers
c5fe6af
@jakehwll
jakehwll requested a review from DanielleMaywood as a code owner September 9, 2026 08:27
@github-actions github-actions Bot assigned jakehwll Sep 9, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-09T08:32:31.187186Z c5fe6af PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jakehwll
jakehwll requested a review from tracyjohnsonux September 9, 2026 08:27
@jakehwll jakehwll changed the title feat(site/src): share org in personal agent model settings feat(site): share org in personal agent model settings Sep 9, 2026
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Sep 9, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c5fe6af162

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread site/src/pages/AgentsPage/AgentSettingsUserAgentsPage.tsx Outdated
Comment on lines +129 to +131
isSaving={saveOverride.isPending && saveMatchesOrganization}
saveContext={
saveMatchesOrganization ? saveOverride.variables?.context : undefined

@chatgpt-codex-connector chatgpt-codex-connector Bot Sep 9, 2026

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Track every in-flight override save

When a user saves another row before the first request finishes, this single mutation observer switches variables to the latest call, so isSaving becomes false for the earlier row even though its request remains active. The user can then edit and resubmit that row; if the older request completes last, it can overwrite the newer selection. Preserve pending state per context, as the previous separate mutations did, or disable all rows while the shared mutation has outstanding requests.

AGENTS.md reference: site/AGENTS.md:L11-L11

Useful? React with 👍 / 👎.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
DanielleMaywood
DanielleMaywood reviewed Sep 9, 2026
View reviewed changes
Comment thread site/src/pages/AgentsPage/AgentSettingsUserAgentsPage.tsx Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread site/src/pages/AgentsPage/AgentSettingsUserAgentsPageView.stories.tsx Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread site/src/pages/AgentsPage/AgentSettingsUserAgentsPageView.tsx Resolved

Uh oh!

There was an error while loading. Please reload this page.
@jakehwll
🤖 fix(site): address personal model settings review feedback
a71de1b
@jakehwll
jakehwll requested a review from a team as a code owner September 28, 2026 13:36
@jakehwll
🤖 chore: merge main into personal model settings
64f31ee
@jakehwll
jakehwll requested a review from DanielleMaywood September 28, 2026 23:27
@linear-code

linear-code Bot commented Sep 30, 2026

Copy link
Copy Markdown

CODAGT-1125
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jakehwll
🤖 chore: merge main into personal agent model settings
e7bf729
DanielleMaywood
DanielleMaywood approved these changes Oct 8, 2026
View reviewed changes
Comment thread site/src/pages/AgentsPage/AgentSettingsUserAgentsPageView.stories.tsx Outdated
Comment on lines +22 to +25
const defaultModelConfig = MockPersonalDefaultChatModel;
const claudeModelConfig = MockPersonalClaudeChatModel;
const reasoningModelConfig = MockPersonalReasoningChatModel;
const modelOptions = MockPersonalModelOptions;

@DanielleMaywood DanielleMaywood Oct 8, 2026

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jakehwll
🤖 refactor(site): remove redundant story fixture aliases
298c233
@jakehwll
jakehwll merged commit 29e876d into main Oct 8, 2026
27 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@jakehwll
jakehwll deleted the jakehwll/refactor-agents-settings-user-agents branch October 8, 2026 12:45
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@DanielleMaywood DanielleMaywood DanielleMaywood approved these changes
@tracyjohnsonux tracyjohnsonux Awaiting requested review from tracyjohnsonux

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@jakehwll jakehwll

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jakehwll @DanielleMaywood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.