GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||
GeezerVison is showing github.com — feat(coderd): evaluate read_template parameters for the chat owner by ibetitsmike · Pull Request #29561 · coder/coder Conversation
|
|
@codex review |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Here are some automated review suggestions for this pull request.
Reviewed commit: 523601e94d
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
… cannot evaluate preview reports a module it cannot load as a module_not_loaded warning and omits every parameter that module declares, so read_template replaced the complete import rows with the incomplete render. The missing parameters are now appended from the import rows with the build-time default note, mirroring dynamicparameters.incompleteRender. An option whose value preview cannot know rendered as an empty string. It now takes the value recorded at import by option name, with an options_note, and is omitted when no import value exists.
|
@codex review |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Here are some automated review suggestions for this pull request.
Reviewed commit: f3c79787e6
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
…e from the import row Option labels can depend on the owner, so recovering an unknown option value by its evaluated label missed the import row and dropped the option. A validation bound preview cannot evaluate comes back nil, the same as an absent one, and was silently omitted although the provisioner enforces it at build time. renderedParameterEntry now omits whatever preview could not evaluate and fills default, options, and validation bounds from the import row in one place, each with a note naming the source. A partially unknown option list is replaced as a whole.
|
@codex review |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Here are some automated review suggestions for this pull request.
Reviewed commit: 00b2f57de8
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
…be prebuild matching renderedOptions treated an empty rendered list as unknown, so a parameter whose option blocks evaluate to nothing for this owner was filled with the importer's options. An empty list is now a known result and is left alone. The build-values note claimed a build matches a preset by the resolved values. wsbuilder records the preset that way, but workspace creation claims a prebuilt workspace from the raw request values only, so an agent relying on defaults misses the prebuild. The note now tells the model to pass preset_id or the preset's parameter values.
|
@codex review |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Here are some automated review suggestions for this pull request.
Reviewed commit: 99a3eca8da
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
…lds from the import row read_template filled a default, option list, or validation bound that preview could not evaluate for the owner from the import-time row. Preview's output carries no signal that distinguishes those from fields that evaluate to null for this owner: a default that depends on data.coder_provisioner and a default that is null for the owner both render as Valid false with no diagnostic, a null validation bound is a nil pointer like an absent one (an unknown bound panics preview and fails the whole render, which already falls back to import rows), and a wholly unknown dynamic option set renders as an empty list with no diagnostic. Every fill therefore guessed on one side of that line, and each review round found the counterexample on the other. Show these fields exactly as preview evaluates them, as the create-workspace form does. An option whose value is unknown is omitted rather than shown empty, and preview's invalid-options error is already surfaced as error. A non-required parameter whose default could not be evaluated gets a default_note saying so instead of a borrowed value. The module_not_loaded whole-parameter fill stays: its diagnostic code is the signal wsbuilder also keys on.
|
@codex review |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Here are some automated review suggestions for this pull request.
Reviewed commit: 47bf7d60cd
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@codex review |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
The build-defaults note promised the values a build uses when a parameter is omitted, but a default that depends on another parameter is re-evaluated against the values create_workspace passes. Say so, and scope the promise to a request that omits every parameter. Import rows carry no module provenance, so the module_not_loaded fill also restores root-level rows the render omitted for this owner. Label every restored row as an import-time estimate instead of noting only its default.
|
@codex review |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
… preset note Report a parameter error only for an evaluated default. With no default, preview and the static renderer validate an empty value, so a required parameter with a validation block, or an optional one whose default could not be evaluated, was reported as broken. Log only diagnostic codes when evaluation falls back, since diagnostic text can quote owner attributes seeded into the render, and skip the warning when the context was cancelled. Qualify the build defaults note for presets matched without a preset_id and for claimed prebuilt workspaces, which keep their own parameter values.
…ate-owner-params # Conflicts: # coderd/export_test.go
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.