GeezerVison

chatgpt-codex-connector Bot left a comment

chatgpt-codex-connector Bot left a comment

chatgpt-codex-connector Bot left a comment

chatgpt-codex-connector Bot left a comment

chatgpt-codex-connector Bot left a comment

…ry transport

Internal MCP servers now return a go-sdk server for each chat, and chatd
connects to it over an in-memory transport at every step. This replaces
the coder-internal:// rows and the in-process HTTP handler transport.

Internal MCP servers no longer share the path of caller-supplied
servers. mcpclient gets an InProcessServer type and a ConnectInProcess
call, with their own caps at today's values. chatd keeps internal
servers in their own list, and adds tool sources in this order:
built-in, internal, admin, workspace, inline. The first tool keeps a
name, so internal tools win over admin and caller tools. Only the
admin and workspace tools that keep their names are deferred behind
find_tools.

…uses them

prepareGeneration called ServerForChat for every chat at every step,
then dropped the result for plan-mode subagents and explore-mode root
chats. turnUsesMCPServers now decides first, with the rule that
filterMCPServersForTurn and the explore-mode root filter apply, and
chatd skips the call when the turn uses no MCP servers.

An error from ServerForChat skipped the server for the step, and only
the debug run recorded it. It now fails turn preparation, as other
reads in turn preparation do, so the prepare retry runs and the chat
shows an error if the error stays. A nil server still means the chat
does not get that server.

…nd table

InternalServer becomes the Root row of InternalServerByChatKind, which
now runs with caller-supplied tools disabled and the inline experiment
off, so every row also proves that internal servers ignore those gates.
Its caller server only repeated the Disabled test. The error half of
TestInternalMCPServersForChat repeats InternalServerError, and its
chat ID check repeats the Root row.

… the turn actor

Tool handlers on an in-process server inherited the values of the context passed to Connect, which carried the chatd dbauthz actor. Connect with a background context so a handler must choose its identity explicitly, and database calls without one fail with ErrNoActor.