GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||
GeezerVison is showing github.com — refactor(site/src/pages/AgentsPage): require always-passed settings and misc props by DanielleMaywood · Pull Request #29892 · coder/coder Conversation
Contributor
Several AgentsPage settings views, header buttons and helpers declared props or parameters optional, but every production caller passes them. These are now required, and the dead defaults, Part of the AgentsPage nullability cleanup; see #29888 for the methodology. Dead slots for this cluster: 20 before, 1 after (the remaining one is This PR was generated by Coder Agents on behalf of @DanielleMaywood.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
There was an error while loading. Please reload this page.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
e512e57 to
e235dd0
Compare
Sorry, something went wrong.
There was an error while loading. Please reload this page.
e235dd0 to
d2f8c80
Compare
…nd misc props Settings views, header buttons and small AgentsPage helpers declared props and parameters optional even though every production caller passes them. Their defaults, fallbacks and guards were dead. Make them required and delete the dead handling. ChimeButton and WebPushButton become controlled-only, dropping their internal chime state, internal useWebpushNotifications() call and fallback toggle branch. Stories now pass the required args.
d2f8c80 to
25bf69e
Compare
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.