GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — refactor(site/src/pages/AgentsPage): require always-passed settings and misc props by DanielleMaywood · Pull Request #29892 · coder/coder

Conversation

@DanielleMaywood

@DanielleMaywood DanielleMaywood commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Several AgentsPage settings views, header buttons and helpers declared props or parameters optional, but every production caller passes them. AgentSettingsCompactionPage always passes an array for models (from useOrganizationChatModels) plus a compactionModelIDByOrganization map. AgentSettingsUserAgentsPage always passes onRetryOverrides and isRetryingOverrides, and AgentSettingsPersonalSkillsPage always passes isExportingAll. AgentCreatePage always passes enabled/onToggle to ChimeButton and webPush/onToggle to WebPushButton. AgentCreateForm always passes onChange to CompactOrgSelector, and AgentChatInput always passes unsupportedProviderNames to AgentSetupNotice (it defaults the value to [] itself). AgentsPageLayout always passes onToggleSearch. getUsableDefaultModelIDForOrganization, resolveCompactionThreshold, getModelDisplayName and changeColor are always called with non-null values, and UsageRingProgress always gets severity.

These are now required, and the dead defaults, ?./&& guards and fallbacks are gone. ChimeButton and WebPushButton are now controlled-only: the internal chime state, the internal useWebpushNotifications() call and the fallback subscribe/unsubscribe/toast branch are removed. getModelDisplayName keeps isUnsetModelRef, since that also treats "" and the nil UUID as unset. The stories now pass the required args. ChimeButton.stories swaps its click-to-toggle story for an explicit Enabled story, so the two visual states stay covered. Left optional on purpose: aiGatewayDisabled and CompactIntegerField.error/disabled (skip list), and ChatsSidebar.canManageAgentSettings, which is narrowed in #29889.

Part of the AgentsPage nullability cleanup; see #29888 for the methodology. Dead slots for this cluster: 20 before, 1 after (the remaining one is canManageAgentSettings, owned by #29889).

This PR was generated by Coder Agents on behalf of @DanielleMaywood.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

chatgpt-codex-connector[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@github-actions github-actions Bot assigned DanielleMaywood Sep 25, 2026
@DanielleMaywood
DanielleMaywood marked this pull request as ready for review September 25, 2026 11:03
@DanielleMaywood
DanielleMaywood requested a review from a team as a code owner September 25, 2026 11:03
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 25, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-25T11:05:45.597520Z e512e57 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@DanielleMaywood
DanielleMaywood force-pushed the nullability/settings-misc branch from e512e57 to e235dd0 Compare September 29, 2026 14:26
@linear-code

linear-code Bot commented Sep 30, 2026

Copy link
Copy Markdown

CODAGT-1258

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jakehwll
jakehwll approved these changes Oct 6, 2026
View reviewed changes
@DanielleMaywood
DanielleMaywood force-pushed the nullability/settings-misc branch from e235dd0 to d2f8c80 Compare October 6, 2026 08:07
jaaydenh
jaaydenh approved these changes Oct 6, 2026
View reviewed changes
@DanielleMaywood
refactor(site/src/pages/AgentsPage): require always-passed settings a…
25bf69e
…nd misc props

Settings views, header buttons and small AgentsPage helpers declared
props and parameters optional even though every production caller
passes them. Their defaults, fallbacks and guards were dead.

Make them required and delete the dead handling. ChimeButton and
WebPushButton become controlled-only, dropping their internal chime
state, internal useWebpushNotifications() call and fallback toggle
branch. Stories now pass the required args.
@DanielleMaywood
DanielleMaywood force-pushed the nullability/settings-misc branch from d2f8c80 to 25bf69e Compare October 6, 2026 11:12
@DanielleMaywood
DanielleMaywood merged commit 33b69ff into main Oct 6, 2026
27 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@DanielleMaywood
DanielleMaywood deleted the nullability/settings-misc branch October 6, 2026 13:19
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jaaydenh jaaydenh jaaydenh approved these changes
@jakehwll jakehwll jakehwll approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@DanielleMaywood DanielleMaywood

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@DanielleMaywood @jaaydenh @jakehwll
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.