GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — refactor(site/src/pages/AgentsPage): require always-passed right panel props by DanielleMaywood · Pull Request #29893 · coder/coder

Conversation

@DanielleMaywood

@DanielleMaywood DanielleMaywood commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Each right panel component has a single production caller (AgentChatPageView, GitPanel, CommentableDiffViewer, DebugPanel, DebugRunCard, DebugStepCard), and those callers always pass these props. That made the optional types, defaults and guards dead. TerminalPanel is only rendered behind workspace && workspaceAgent, so its "agent not ready" fallback could never render. DebugStepCard.defaultOpen was always false, so the prop is removed. DebugRunCard no longer needs its own download = saveAs default, because DebugPanel owns that default and always forwards download.

This change makes the following props required: isExpanded/chatInputRef through GitPanel → RemoteDiffPanel/LocalDiffPanel → CommentableDiffViewer → DiffViewer, plus DiffViewer's line callbacks and annotationsVersion's input; GitPanel.isGitStatusLoading/everDirty; TerminalPanel.workspace/workspaceAgent/isHot/autoFocus/onReady; DesktopPanel.isVisible and DesktopPanelView.onPopOut; RightPanelAddTabControl.host/isRunning/onOpenWorkspaceApp/onOpenCommandApp/onOpenPort; DebugPanel.isVisible; DebugRunList/DebugRunCard.download; PillToggle.count; ToolEventCard.copyLabel; and debugExportFilename's exportedAt. The DiffViewer, GitPanel and TerminalPanel stories now pass the required args. The TerminalPanel AgentUnavailable story and the annotationsVersion(undefined) assertion are removed because production cannot reach them. These stay optional on purpose: DebugPanel.download (a test injection point that defaults to saveAs), DesktopToolbar.onPopOut (the pop-out page omits it), and LocalRepoContent.repo (it comes from Map.get).

Part of the AgentsPage nullability cleanup; see #29888 for the methodology. Dead slots in the right panel cluster: 39 before, 0 after.

This PR was generated by Coder Agents on behalf of @DanielleMaywood.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

chatgpt-codex-connector[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@github-actions github-actions Bot assigned DanielleMaywood Sep 25, 2026
@DanielleMaywood
DanielleMaywood marked this pull request as ready for review September 25, 2026 11:14
@DanielleMaywood
DanielleMaywood requested a review from a team as a code owner September 25, 2026 11:14
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 25, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-25T11:18:17.797362Z 1ed8418 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@DanielleMaywood DanielleMaywood mentioned this pull request Sep 25, 2026
refactor(site/src/pages/AgentsPage): carry diff status in git panel PR tab #29904
Closed
@DanielleMaywood
refactor(site/src/pages/AgentsPage): require always-passed right pane…
52f103b
…l props

The right panel components (Git diff viewer, terminal, desktop, add-tab
control and debug panel) each have a single production caller that
always passes these props, so their optional types, defaults and
guards were dead.

Narrow the diff viewer callbacks, isExpanded and chatInputRef through
GitPanel, LocalDiffPanel, RemoteDiffPanel, CommentableDiffViewer and
DiffViewer; require TerminalPanel's workspace, agent, isHot, autoFocus
and onReady and drop its unreachable no-agent fallback; require
DesktopPanel.isVisible, DesktopPanelView.onPopOut, the add-tab
control's host, isRunning and open callbacks, and DebugPanel.isVisible.
In the debug panel, DebugRunList/DebugRunCard.download, PillToggle.count,
ToolEventCard.copyLabel and debugExportFilename's exportedAt become
required, and DebugStepCard loses its always-false defaultOpen prop.

Stories now pass the required values, the TerminalPanel
AgentUnavailable story and the annotationsVersion(undefined) assertion
are removed because production cannot reach them.
@DanielleMaywood
DanielleMaywood force-pushed the nullability/right-panel branch from 1ed8418 to 52f103b Compare September 29, 2026 14:29
@linear-code

linear-code Bot commented Sep 30, 2026

Copy link
Copy Markdown

CODAGT-1258

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jakehwll
jakehwll approved these changes Oct 6, 2026
View reviewed changes
@DanielleMaywood
DanielleMaywood merged commit 21212e4 into main Oct 6, 2026
27 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@DanielleMaywood
DanielleMaywood deleted the nullability/right-panel branch October 6, 2026 07:35
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakehwll jakehwll jakehwll approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@DanielleMaywood DanielleMaywood

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@DanielleMaywood @jakehwll
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.