GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||
GeezerVison is showing github.com — refactor(site/src/pages/AgentsPage): require always-passed right panel props by DanielleMaywood · Pull Request #29893 · coder/coder Conversation
Contributor
Each right panel component has a single production caller ( This change makes the following props required: Part of the AgentsPage nullability cleanup; see #29888 for the methodology. Dead slots in the right panel cluster: 39 before, 0 after. This PR was generated by Coder Agents on behalf of @DanielleMaywood.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
There was an error while loading. Please reload this page.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…l props The right panel components (Git diff viewer, terminal, desktop, add-tab control and debug panel) each have a single production caller that always passes these props, so their optional types, defaults and guards were dead. Narrow the diff viewer callbacks, isExpanded and chatInputRef through GitPanel, LocalDiffPanel, RemoteDiffPanel, CommentableDiffViewer and DiffViewer; require TerminalPanel's workspace, agent, isHot, autoFocus and onReady and drop its unreachable no-agent fallback; require DesktopPanel.isVisible, DesktopPanelView.onPopOut, the add-tab control's host, isRunning and open callbacks, and DebugPanel.isVisible. In the debug panel, DebugRunList/DebugRunCard.download, PillToggle.count, ToolEventCard.copyLabel and debugExportFilename's exportedAt become required, and DebugStepCard loses its always-false defaultOpen prop. Stories now pass the required values, the TerminalPanel AgentUnavailable story and the annotationsVersion(undefined) assertion are removed because production cannot reach them.
1ed8418 to
52f103b
Compare
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.