GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat!: confirm role changes in coder users edit-roles by nickvigilante · Pull Request #30140 · coder/coder

Conversation

@nickvigilante

@nickvigilante nickvigilante commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

coder users edit-roles --roles ... replaces the user's whole set of site roles, so granting one role could silently remove others, including owner.
It registered -y but never prompted, and -y didn't skip the interactive role picker.

It now prints the roles being added and removed and asks for confirmation; -y skips it.
The --roles help says it replaces the full set.

Behavior change: New prompt; can break scripts. edit-roles --roles ... without -y now prompts.
-y without --roles now fails with an error instead of opening the picker.
If the requested roles match the current roles, it prints No role changes for <user>. and doesn't prompt.

Decisions
  • No-op requests skip the prompt so idempotent scripted calls stay quiet.

Closes CLI-21

This PR was generated by Coder Agents on behalf of @nickvigilante.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nickvigilante
feat: confirm role changes in coder users edit-roles
92d4238 
`coder users edit-roles --roles ...` replaces the user's whole set of
site roles, so granting one role could silently remove others, including
owner. It registered `-y` but never prompted, and `-y` didn't skip the
interactive role picker.

Linear: CLI-21
@linear-code

linear-code Bot commented Sep 30, 2026

Copy link
Copy Markdown

CLI-21
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot assigned nickvigilante Sep 30, 2026
@nickvigilante
nickvigilante marked this pull request as ready for review September 30, 2026 01:14
@nickvigilante
nickvigilante requested a review from matifali September 30, 2026 01:14
matifali
matifali approved these changes Sep 30, 2026
View reviewed changes
@nickvigilante nickvigilante changed the title feat: confirm role changes in coder users edit-roles feat!: confirm role changes in coder users edit-roles Sep 30, 2026
@github-actions github-actions Bot added the release/breaking This label is applied to PRs to detect breaking changes as part of the release process label Sep 30, 2026
@nickvigilante
nickvigilante merged commit cf60604 into main Sep 30, 2026
83 of 87 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@nickvigilante
nickvigilante deleted the vigilante/cli-21-coder-users-edit-roles-confirm-before-replacing-a-users branch September 30, 2026 16:36
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@matifali matifali matifali approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@nickvigilante nickvigilante

Labels

release/breaking This label is applied to PRs to detect breaking changes as part of the release process

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@nickvigilante @matifali
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.