GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat!: confirm before coder update restarts a running workspace by nickvigilante · Pull Request #30150 · coder/coder

Conversation

@nickvigilante

@nickvigilante nickvigilante commented Sep 30, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

coder update stopped and restarted a running workspace without asking and had no -y, while coder restart and the dashboard's update dialog both confirm first.

It now asks for confirmation before stopping a running workspace, using the dashboard's wording that updating can delete non-persistent data.
-y skips it, and also answers the existing "Enqueue another stop?" prompt.

Behavior change: New prompt; can break scripts. coder update on a running workspace without -y now blocks on stdin, or fails if stdin is closed.
Stopped workspaces don't prompt.
Parameter prompts such as --always-prompt aren't affected by -y.

The Update workspaces guide now notes the prompt and -y.

Decisions
  • Mirrors coder restart's prompt pattern.
  • Doc-check suggested a row in the 2.29 to 2.34 ESR upgrade guide. This change ships after 2.34, so it's documented in the user guide instead.

Closes CLI-34

This PR was generated by Coder Agents on behalf of @nickvigilante.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nickvigilante
feat: confirm before coder update restarts a running workspace
1adfcc2 
`coder update` stopped and restarted a running workspace without asking
and had no `-y`, while `coder restart` and the dashboard's update dialog
both confirm first.

Linear: CLI-34
@linear-code

linear-code Bot commented Sep 30, 2026

Copy link
Copy Markdown

CLI-34
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot assigned nickvigilante Sep 30, 2026
@nickvigilante
nickvigilante marked this pull request as ready for review September 30, 2026 02:57
@nickvigilante
nickvigilante requested a review from matifali September 30, 2026 02:57
@coderagents

coderagents Bot commented Sep 30, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Documentation Check

Updates Needed

  • docs/install/operate/upgrade/esr-2.29-2.34-upgrade.md (open) - Initially suggested a row in the ESR upgrade table. Author noted this change ships after 2.34, so it was documented in the user guide instead (correct).
  • docs/user-guides/workspace-management.md (open) - Notes the confirmation prompt for running workspaces and documents -y for non-interactive/scripted use.
  • docs/reference/cli/update.md - New -y, --yes flag is covered by the regenerated CLI reference in this PR.

Automated review via Coder Agents
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
matifali
matifali approved these changes Sep 30, 2026
View reviewed changes

@matifali matifali left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I think we should mark this as a breaking chnage.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
nickvigilante reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@matifali matifali changed the title feat: confirm before coder update restarts a running workspace feat!: confirm before coder update restarts a running workspace Sep 30, 2026
@github-actions github-actions Bot added the release/breaking This label is applied to PRs to detect breaking changes as part of the release process label Sep 30, 2026
@nickvigilante
docs: note the coder update confirmation prompt
4f227b3 
Document that coder update now asks for confirmation before updating a
running workspace, and that -y skips the prompt for scripted use.

Linear: CLI-34
@github-actions

github-actions Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Docs preview

Check off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here.

  • docs/user-guides/workspace-management.md
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nickvigilante
nickvigilante merged commit b6aab35 into main Sep 30, 2026
36 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@nickvigilante
nickvigilante deleted the vigilante/cli-34-coder-update-confirm-before-restarting-the-workspace-like branch September 30, 2026 18:31
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@matifali matifali matifali approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@nickvigilante nickvigilante

Labels

release/breaking This label is applied to PRs to detect breaking changes as part of the release process

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@nickvigilante @matifali
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.