GeezerVison is showing github.com — feat: remove model_intent from the execute, process_output, and advisor tools by ibetitsmike · Pull Request #30397 · coder/coder
Conversation
ibetitsmike
commented
Oct 6, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
The built-in execute, process_output, and advisor tools offered an optional model_intent argument whose text replaced the tool row's default label. Models fill it inconsistently, so most chats mixed intent labels with plain command labels. On dogfood over three days, Claude Opus 5.5 sent it on 17% of execute calls through Bedrock and 30% through the Anthropic API. The rate follows reasoning effort: the few chats at max or xhigh effort sent it on every call, while chats at high, medium, or default effort sent it on about a third of calls or fewer.
This removes the argument from the three tool schemas and always renders the command-based labels ("Ran ...", "Started ... in the background", "Checked ...", "Consulted the advisor"). It also deletes the frontend helpers, tests, and stories that existed only for the intent labels.
- Old chats keep working. chatd's decoders and its tool input check ignore undeclared keys, so calls that still carry
model_intent run as before and their rows show the default label.
- The per-server
model_intent option for MCP tools is unchanged. That field is required in the schema, and Opus 5.5 fills it on 96 to 99.7% of those calls.
- The MCP workspace
execute and process_output tools now match the Coder Agents contract apart from their workspace argument, so the golden test drops its Agents-only exception.
- Pixel diffs from this change: the deleted intent stories and the new default labels in
AllToolIconsTranscript, PolicyBadgeCoversEveryRenderer, and StreamedAdvisorResultOverlaysDurableCall.
Testing
go test for chattool, chatadvisor, toolschema, coderd/mcp, and coderd/x/chatd -run Advisor; go vet ./coderd/x/chatd/... ./coderd/mcp/....
- Red check: re-adding the field to
ExecuteArgs fails TestWorkspaceToolsGolden.
- Vitest unit tests for the tool utils, the generic tool row, and chat parsing (5 files) and the affected Storybook files (4 files);
biome, oxlint, and tsc.
make pre-commit passed on the rebased head. The pre-push hook was skipped per the maintainer's standing preference; CI covers it.
Review record
frontend-review (FE1 to FE10): all PASS or N/A.
coder-frontend-review (8 parallel reviewer roles): no findings. Two optional side notes were declined: a nested ternary for ExecuteTool's label (SD3 discourages them) and a story for an old call that still carries model_intent (TS7: it shows the same state as the existing default-label stories).
Xum opened this PR on behalf of @ibetitsmike.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
chatgpt-codex-connector[bot] reacted with thumbs up emoji
Codex Review Summary
This comment shows the latest Codex review activity on this pull request.
| Review |
Status |
Commit |
Review trigger |
| 📝 Code Review |
✅ Completed 2026-10-06T12:20:19.322121Z |
d554e52 |
Draft marked ready |
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review" or "@codex security review".
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…or tools
The built-in execute, process_output, and advisor tools offered an
optional model_intent argument whose text replaced the default tool row
label. Models fill it inconsistently: Claude Opus 5.5 below xhigh
reasoning effort usually omits it, so most chats mixed intent labels and
command labels. Remove the argument from the three tool schemas and
always render the command-based labels.
Persisted calls that still carry model_intent keep working: chatd's
decoders ignore undeclared keys, and their rows show the default label.
The per-server model_intent option for MCP tools is unchanged.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
jakehwll
jakehwll approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|