GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — feat(site/src/pages/AgentsPage): quieter read-only view for other users' chats by tracyjohnsonux · Pull Request #30483 · coder/coder

Conversation

tracyjohnsonux commented Oct 7, 2026 •

edited by coder Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

When a user opens a chat owned by someone else, the page showed an orange warning band and a full composer whose controls were all disabled. This replaces that with a quieter read-only view.

Top bar: no warning band. The share button is shown only to the chat owner, so viewers with share permission (admins) no longer get it. The shared-chat icon by the title is unchanged, and the kebab stays (it holds Copy ID).
Composer: the "This chat is owned by X. It is read-only." message moves inside as a neutral info line. The editor is not rendered, so the composer is short, and it gets the default border.
Composer controls: +, mic, send/stop and the x on workspace, MCP and planning pills are hidden. Model, workspace and MCP pills and the context indicator stay; the model shows as a plain label rather than a disabled picker.

The compact view is driven by a new readOnlyNotice prop on AgentChatInput, so the new-chat form, which also uses isReadOnly, is unchanged. Sidebar rows and message action rows are out of scope.

Fixes CODAGT-1355

Follow-ups (cleanup tracked in CODAGT-1384):

CODAGT-1385: split the read-only composer out of AgentChatInput (replaces readOnlyNotice).
CODAGT-1386: use one viewer-permission check across the chat page.
CODAGT-1387: audit read-only treatment for sidebar rows and message actions.
CODAGT-1308: read-only viewers still see an enabled "Remove from queue" button (existing).

Design decisions

From design review with Tracy:

Remove the red warning band.
Remove the share button for non-owners. A lock and then a moved shared icon were tried; the existing shared icon by the title was kept instead.
Move the warning message into the chat area.
Make the chat area smaller and outline it so it looks different.
Remove disabled action buttons in the chat area (only show content the user can interact with): +, mic, send, and the pill x buttons. The spinner in the mockup is the existing context indicator, which stays.

Verified in Storybook (AgentChatPageView / OtherUserChatReadOnly): the composer shows the notice, has no editor, its only button is the context indicator, and the orange band is gone. New visual story: AgentChatInput / ReadOnlyNotice.

Generated by Coder Agents.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          feat(site/src/pages/AgentsPage): quieter read-only view for other use…

d8103ba

…rs' chats

Replace the orange owner banner with a neutral notice inside the
composer, drop the editor and all action controls (plus menu, mic,
send, pill dismiss buttons) for read-only viewers, outline the
composer with the default border, and show a lock icon in the top bar
instead of the shared-chat icon.

Fixes CODAGT-1355

linear-code Bot commented Oct 7, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

CODAGT-1355

CODAGT-1384

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot assigned tracyjohnsonux

Oct 7, 2026

tracyjohnsonux added 3 commits

October 7, 2026 21:38


          fix(site/src/pages/AgentsPage): show the model as a static pill in re…

a07a6e2

…ad-only chats

The disabled model selector rendered greyed out next to the other
context pills. Read-only viewers cannot change the model, so render a
plain label that matches the MCP pills instead.


          fix(site/src/pages/AgentsPage): size the read-only lock like the top …

96589af

…bar icons

Button forces icons to size-icon-sm with p-0.5 inside a size-7 box, so
the bare 16px lock rendered larger than its neighbours. Use the same
box and glyph sizing.


          Merge branch 'main' into tracy/codagt-1355-read-only-chat-composer

1a9175e

tracyjohnsonux marked this pull request as ready for review

October 7, 2026 21:46

tracyjohnsonux requested a review from a team as a code owner

October 7, 2026 21:46

tracyjohnsonux added 3 commits

October 7, 2026 21:50


          chore(site/src/pages/AgentsPage): tighten readOnlyNotice prop comment

db1de2f


          Merge branch 'tracy/codagt-1355-read-only-chat-composer' of https://g…

73c1bd5

…ithub.com/coder/coder into tracy/codagt-1355-read-only-chat-composer


          fix(site/src/pages/AgentsPage): hide the share button on other users'…

402b77e

… chats

Viewers with the share permission (owners, org admins) still saw the
share button next to the lock on chats they do not own. Show it only
to the chat owner.

pr-queue-manager Bot requested a review from DanielleMaywood

October 8, 2026 20:07

DanielleMaywood approved these changes

Oct 9, 2026

View reviewed changes

DanielleMaywood left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving although we're making our components even more slop with this change. What I mean is: we're adding an optional prop readOnlyNotice that, when set, hides the editor and controls. It just "feels" wrong. I'm going to noodle on the component architecture a little bit outside of this PR

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

site/src/pages/AgentsPage/components/ChatTopBar.tsx Outdated

		<div className="flex items-center gap-2">
		{!isEmbedded && canShareChat && chat && (
		{!isEmbedded && isReadOnlyViewer && (
		// Matches the icon buttons' box and glyph size so it reads as a peer.

DanielleMaywood Oct 9, 2026

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yap

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

DanielleMaywood approved these changes

Oct 9, 2026

View reviewed changes

DanielleMaywood left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

tracyjohnsonux added 4 commits

October 9, 2026 21:57


          chore(site/src/pages/AgentsPage): drop comments that restate the code

b2cc7ac


          Merge remote-tracking branch 'origin/main' into tracy/codagt-1355-rea…

1df1b84

…d-only-chat-composer

# Conflicts:
#	site/src/pages/AgentsPage/components/ChatTopBar.tsx


          fix(site/src/pages/AgentsPage): use the shared icon instead of a lock…

a2822a3

… for viewers


          fix(site/src/pages/AgentsPage): keep the shared icon by the title for…

f26497a

… viewers

Restore the existing shared-chat indicator next to the title instead of
moving it into the actions area.

tracyjohnsonux commented Oct 10, 2026

Copy link

Copy Markdown

Contributor Author

Approving although we're making our components even more slop with this change. What I mean is: we're adding an optional prop readOnlyNotice that, when set, hides the editor and controls. It just "feels" wrong. I'm going to noodle on the component architecture a little bit outside of this PR

I've made some issues (in description) to capture future work.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tracyjohnsonux merged commit 8697b91 into main

Oct 10, 2026

35 checks passed

Uh oh!

There was an error while loading. Please reload this page.

tracyjohnsonux deleted the tracy/codagt-1355-read-only-chat-composer branch

October 10, 2026 00:23

github-actions Bot locked and limited conversation to collaborators

Oct 10, 2026

Reviewers

DanielleMaywood

DanielleMaywood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

tracyjohnsonux

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

tracyjohnsonux commented Oct 7, 2026 • edited by coder Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear-code Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DanielleMaywood left a comment

Choose a reason for hiding this comment

Uh oh!

DanielleMaywood Oct 9, 2026

Choose a reason for hiding this comment

Uh oh!

DanielleMaywood left a comment

Choose a reason for hiding this comment

Uh oh!

tracyjohnsonux commented Oct 10, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tracyjohnsonux commented Oct 7, 2026 •

edited by coder Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

linear-code Bot commented Oct 7, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.