GeezerVison is showing github.com — refactor(enterprise/coderd): extract AI model price body decoding and validation by SasSwart · Pull Request #30716 · coder/coder
Conversation
SasSwart
commented
Oct 13, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Moves request body decoding and per-price validation out of the site-wide upsertAIModelPrices handler, so the organization price handler later in this stack can reuse them.
- The handler still reads the body and writes the HTTP errors.
writeAIModelPricesBodyReadError picks 413 or 400.
decodeAIModelPricesBody only decodes, and returns an error.
aiModelPriceKeys holds the JSON keys present in one price, so validation can tell an explicit null apart from a missing price.
validateAIModelPriceValues checks the four prices of one model price. It takes them as an aiModelTokenPrices struct, so callers set each price by name and cannot pass them in the wrong order.
No behavior change. The existing TestUpsertAIModelPrices, TestListAIModelPrices and TestValidateAIModelPrices cover the site-wide handler.
Used later: #30720 reuses the body read error, the price keys and the value validation for its single-price upsert.
This PR was generated by Coder Agents on behalf of @SasSwart.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Oct 13, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
… decoding
The handler reads the body and writes errors. decodeAIModelPricesBody only
decodes and returns an error. aiModelPriceKeys names the keys present in a
price, which tell an explicit null apart from a missing price.
Group the four token prices passed to validateAIModelPriceValues into
aiModelTokenPrices, so callers set each price by name and cannot pass
them in the wrong order.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|