GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||
GeezerVison is showing github.com — feat(site/src/pages/AgentsPage): move View PR into the git panel toolbar by ibetitsmike · Pull Request #30751 · coder/coder Conversation
|
| Before | After |
|---|---|
![]() |
![]() |
At 360 px with PRs in two repos (new NarrowPanelMultipleOrigins story), the switcher label truncates before View PR does:
Pixel baselines change for the GitPanel stories that show a PR. That is expected.
Known tradeoff: View PR takes about 87 px of the toolbar row, so near the 360 px minimum panel width, or with PRs in two repos, the switcher label truncates with an ellipsis. The full label stays in the dropdown. Shortening the label is out of scope here.
Follow-up: GitPanel.tsx was over the 500-line file guideline before this PR (882 lines, now 900). Splitting it is a separate refactor.
pnpm check, pnpm lint, the GitPanel unit tests (9), and the GitPanel story tests (19) pass.pr_number and a /pull/ URL. It fails when the gate reads only pr_number.frontend-review (FE1 to FE10), frontend-deep-review, and coder-frontend-review ran for four rounds, until no role had an open finding.ViewPrButton component with a named props type, and the older-ref test was added.RemoteDiffPanel, which right-aligns the diff stats; the existing selectedPrNumber derivation, because the shared prNumber() helper treats pr_number 0 differently; the github.example.com host in the new story, where coder-frontend-review TS3 asks for *.example.com but the file's older fixtures use github.com; and the file split (follow-up above).Xum opened this PR on behalf of @ibetitsmike.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
The View PR link moves from the remote diff's branch sub-header to the git panel toolbar, between the view switcher and the diff controls, and now uses the shared Button. It still renders only for a selected ref with a PR.
…PrButton, test legacy PR refs Review follow-up. The toolbar's View PR link renders through a module-level ViewPrButton, and a Vitest case covers a legacy ref whose PR number comes only from its URL.
…utton props, tidy legacy-ref test Review follow-up: ViewPrButton gets a named props type, and the legacy-ref fixture uses an example.com URL without the schema comment.
… PR fixture in the legacy-ref test The legacy-ref case now overrides only pr_number and inherits the shared MockChatDiffStatus URL and origin, so the test adds no new hostname literal and its URL host matches its remote origin.
|
@codex review |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Here are some automated review suggestions for this pull request.
Reviewed commit: 44e4781b8e
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@codex review |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.