GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(site/src/pages/AgentsPage): move View PR into the git panel toolbar by ibetitsmike · Pull Request #30751 · coder/coder

Conversation

@ibetitsmike

@ibetitsmike ibetitsmike commented Oct 14, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

The View PR link moves from the branch row of the remote diff (RemoteDiffPanel) to the git panel toolbar, between the view switcher and the diff controls, and now uses the shared Button. It still shows only when the selected ref has a PR (a pr_number, or a PR number parsed from its URL), because a branch-only ref's URL can point at its branch instead of a PR.

Before After
Before: View PR sits on the branch row below the PR title After: View PR sits in the toolbar next to the view switcher

At 360 px with PRs in two repos (new NarrowPanelMultipleOrigins story), the switcher label truncates before View PR does:

Narrow panel: the switcher label truncates and View PR stays whole

Pixel baselines change for the GitPanel stories that show a PR. That is expected.

Known tradeoff: View PR takes about 87 px of the toolbar row, so near the 360 px minimum panel width, or with PRs in two repos, the switcher label truncates with an ellipsis. The full label stays in the dropdown. Shortening the label is out of scope here.

Follow-up: GitPanel.tsx was over the 500-line file guideline before this PR (882 lines, now 900). Splitting it is a separate refactor.

Testing

  • pnpm check, pnpm lint, the GitPanel unit tests (9), and the GitPanel story tests (19) pass.
  • The per-ref test now checks that View PR links to the selected ref's PR after a ref switch. It fails when the link uses the primary ref's URL. The href is the link target, which no screenshot shows, so it stays a Vitest assertion (FE1).
  • A new test covers an older ref with no pr_number and a /pull/ URL. It fails when the gate reads only pr_number.

Review record

  • frontend-review (FE1 to FE10), frontend-deep-review, and coder-frontend-review ran for four rounds, until no role had an open finding.
  • Fixed: the View PR markup moved into a ViewPrButton component with a named props type, and the older-ref test was added.
  • Kept: the href assertions (above); the badge wrapper in RemoteDiffPanel, which right-aligns the diff stats; the existing selectedPrNumber derivation, because the shared prNumber() helper treats pr_number 0 differently; the github.example.com host in the new story, where coder-frontend-review TS3 asks for *.example.com but the file's older fixtures use github.com; and the file split (follow-up above).

Xum opened this PR on behalf of @ibetitsmike.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

chatgpt-codex-connector[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
ibetitsmike added 4 commits October 12, 2026 12:53
@ibetitsmike
feat(site/src/pages/AgentsPage): move View PR into the git panel toolbar
73b4dc1
The View PR link moves from the remote diff's branch sub-header to the
git panel toolbar, between the view switcher and the diff controls, and
now uses the shared Button. It still renders only for a selected ref
with a PR.
@ibetitsmike
refactor(site/src/pages/AgentsPage/components/GitPanel): extract View…
c6f2534
…PrButton, test legacy PR refs

Review follow-up. The toolbar's View PR link renders through a
module-level ViewPrButton, and a Vitest case covers a legacy ref whose
PR number comes only from its URL.
@ibetitsmike
refactor(site/src/pages/AgentsPage/components/GitPanel): name ViewPrB…
458b870
…utton props, tidy legacy-ref test

Review follow-up: ViewPrButton gets a named props type, and the
legacy-ref fixture uses an example.com URL without the schema comment.
@ibetitsmike
test(site/src/pages/AgentsPage/components/GitPanel): reuse the shared…
44e4781
… PR fixture in the legacy-ref test

The legacy-ref case now overrides only pr_number and inherits the
shared MockChatDiffStatus URL and origin, so the test adds no new
hostname literal and its URL host matches its remote origin.
@github-actions github-actions Bot assigned ibetitsmike Oct 14, 2026
@ibetitsmike

ibetitsmike commented Oct 14, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-14T12:22:24.164365Z 44e4781 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 44e4781b8e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ibetitsmike
ibetitsmike marked this pull request as ready for review October 14, 2026 12:04
@ibetitsmike
ibetitsmike requested a review from a team as a code owner October 14, 2026 12:04
@pr-queue-manager
pr-queue-manager Bot requested a review from DanielleMaywood October 14, 2026 12:04
DanielleMaywood
DanielleMaywood approved these changes Oct 14, 2026
View reviewed changes
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Oct 14, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 44e4781b8e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread site/src/pages/AgentsPage/components/GitPanel/GitPanel.test.tsx Resolved

Uh oh!

There was an error while loading. Please reload this page.

@ibetitsmike

ibetitsmike commented Oct 14, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 44e4781b8e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ibetitsmike
ibetitsmike merged commit 05fa806 into main Oct 14, 2026
39 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@ibetitsmike
ibetitsmike deleted the mike/git-panel-view-pr branch October 14, 2026 12:23
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 14, 2026
@ibetitsmike

ibetitsmike commented Oct 14, 2026

Copy link
Copy Markdown
Collaborator Author

Xum merged this PR on behalf of @ibetitsmike after CI passed and Codex returned no findings on 44e4781.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@DanielleMaywood DanielleMaywood DanielleMaywood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ibetitsmike ibetitsmike

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ibetitsmike @DanielleMaywood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.