GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test(agent/x/agentacp): cover session runtime and transcripts by hugodutka · Pull Request #30841 · coder/coder

Conversation

@hugodutka

@hugodutka hugodutka commented Oct 15, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Cover agent-local ACP session initialization, configuration, environment propagation, permission callbacks, and transcript ordering with a fake harness. Verify busy-session rejection, interruption, write deadlines, and preservation of partial output after failures.

Depends on #30835.

Generated with Codex, carefully reviewed by Hugo.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-actions github-actions Bot assigned hugodutka Oct 15, 2026
@hugodutka
hugodutka added this pull request to stack #30843 October 15, 2026 13:08
@hugodutka
hugodutka force-pushed the hugodutka/acp-session-runtime-tests branch from 8d9fb20 to dd5c5bb Compare October 15, 2026 15:48
@hugodutka
hugodutka removed this pull request from stack #30843 October 15, 2026 15:50
@hugodutka
hugodutka added this pull request to stack #30859 October 15, 2026 16:13
@hugodutka
hugodutka force-pushed the hugodutka/acp-session-runtime-tests branch from dd5c5bb to fbcfd0f Compare October 15, 2026 17:31
@hugodutka
hugodutka force-pushed the hugodutka/acp-session-runtime-tests branch from fbcfd0f to adcd9f6 Compare October 16, 2026 15:19
@hugodutka
hugodutka removed this pull request from stack #30859 October 16, 2026 15:20
@hugodutka
hugodutka added this pull request to stack #30904 October 16, 2026 15:21
@hugodutka
hugodutka force-pushed the hugodutka/acp-session-runtime-tests branch from adcd9f6 to 26a8730 Compare October 16, 2026 17:01
@hugodutka
hugodutka force-pushed the hugodutka/acp-session-runtime-tests branch from 26a8730 to 0a543b4 Compare October 19, 2026 12:06
@hugodutka
hugodutka force-pushed the hugodutka/acp-session-runtime-tests branch from 0a543b4 to 43aed04 Compare October 19, 2026 12:58
@hugodutka
hugodutka removed this pull request from stack #30904 October 19, 2026 14:05
@hugodutka
hugodutka added this pull request to stack #31024 October 19, 2026 14:05
@hugodutka
hugodutka force-pushed the hugodutka/acp-session-runtime-tests branch from 43aed04 to 5cdc9e7 Compare October 20, 2026 15:23
@hugodutka
hugodutka force-pushed the hugodutka/acp-session-runtime-tests branch 2 times, most recently from 8518db6 to 4910eb8 Compare October 20, 2026 17:25
@hugodutka
hugodutka force-pushed the hugodutka/acp-session-runtime-tests branch from 4910eb8 to d020d52 Compare October 20, 2026 17:51
@hugodutka
hugodutka removed this pull request from stack #31024 October 20, 2026 17:52
@hugodutka
hugodutka force-pushed the hugodutka/acp-session-runtime-tests branch from d020d52 to d19a6cc Compare October 20, 2026 18:17
@hugodutka
hugodutka force-pushed the hugodutka/acp-session-runtime-tests branch from b128ded to 68bc5eb Compare October 21, 2026 12:19
@hugodutka
hugodutka force-pushed the hugodutka/acp-session-runtime-tests branch 2 times, most recently from d162b8e to d7425e9 Compare October 21, 2026 13:36
@hugodutka
hugodutka force-pushed the hugodutka/acp-session-runtime-tests branch from d7425e9 to 2d44391 Compare October 21, 2026 13:49
@hugodutka
hugodutka force-pushed the hugodutka/acp-session-runtime-tests branch from 2d44391 to ff3b26f Compare October 21, 2026 14:19
@hugodutka
hugodutka force-pushed the hugodutka/acp-session-runtime-tests branch from ff3b26f to e177e7b Compare October 21, 2026 14:21
@hugodutka
hugodutka force-pushed the hugodutka/acp-session-runtime-tests branch from e177e7b to 3cf46e8 Compare October 21, 2026 16:12
@hugodutka hugodutka mentioned this pull request Oct 21, 2026
feat: watch and subscribe to ACP session updates #30903
Merged
@hugodutka
hugodutka added this pull request to stack #31131 October 21, 2026 16:34
@hugodutka
hugodutka marked this pull request as ready for review October 21, 2026 16:36
@hugodutka
hugodutka force-pushed the hugodutka/acp-session-runtime-tests branch from 3cf46e8 to 8a991b4 Compare October 21, 2026 16:56
@mafredri
mafredri self-requested a review October 22, 2026 09:44
mafredri
mafredri approved these changes Oct 22, 2026
View reviewed changes

@mafredri mafredri left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, but I didn't review the tests in-depth.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugodutka
hugodutka force-pushed the hugodutka/acp-session-runtime-tests branch from 8a991b4 to a059fca Compare October 22, 2026 20:31
@hugodutka
hugodutka force-pushed the hugodutka/acp-session-runtime-tests branch from a059fca to 835988c Compare October 23, 2026 11:14
@hugodutka
hugodutka force-pushed the hugodutka/acp-session-runtime-tests branch from 835988c to 2e9aa39 Compare October 23, 2026 11:34
@hugodutka
test(agent/x/agentacp): cover session runtime and transcripts
f097992
@hugodutka
hugodutka force-pushed the hugodutka/acp-session-runtime-tests branch from 2e9aa39 to f097992 Compare October 26, 2026 16:01
@hugodutka
hugodutka merged commit 9add27f into main Oct 26, 2026
32 of 52 checks passed

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mafredri mafredri mafredri approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@hugodutka hugodutka

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hugodutka @mafredri
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.