GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — ci(.github/workflows): remove nix from dogfood image matrix (backport 2.34) by droopy4096 · Pull Request #30858 · coder/coder

Conversation

@droopy4096

@droopy4096 droopy4096 commented Oct 15, 2026 •
edited by coder Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Removes the nix dev image from .github/workflows/dogfood.yaml on release/2.34, aligning it with release/2.35 and later (["22.04", "26.04"]). Tracked in ENT-214.

Why

build_image (nix) fails on every release/2.34 PR that triggers the dogfood workflow (e.g. #30811):

error: cannot download google-chrome-stable_143.0.7499.169-1_amd64.deb from any mirror (HTTP 404)

The nix dev image includes google-chrome from the nixos-25.05 nixpkgs pinned in this branch's flake.lock. Google only serves recent Chrome builds, so the pinned .deb is gone. main removed the nix image in #26022 after 2.34 was cut, so only this branch still builds it. Bumping nixpkgs instead would change many packages on an old release branch, and the Chrome pin would go stale again.

Changes

.github/workflows/dogfood.yaml only, mirroring the workflow part of #26022:

  • Drop nix from the build_image matrix.
  • Remove the nix-only steps: Nix install, cache-nix-action, nix build .#dev_image, and the codercom/oss-dogfood-nix push.
  • Drop the matrix.image-version != 'nix' guards, which are now always true.
  • Drop the flake.nix / flake.lock path triggers, since no job in this workflow uses the flake anymore.
  • Update comments that mentioned the nix image.

Not touched, to keep the backport small: flake.nix (dev_image output), nix/docker.nix, and the nix image option in dogfood/coder/main.tf. None of them is used by CI after this change.

Notes

  • Analyze PR for Documentation Updates Needed fails here for an unrelated reason (outdated agents-chat-action pin, fixed by ci: bump agents-chat-action to v0.5.1 in doc-check (backport 2.34) #30850 / ENT-212).
  • chromatic fails on all release/2.34 PRs ("No app with code ... found"), also unrelated.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@droopy4096
Removing nix from matrix to match rest of releases
ca869ed
@droopy4096
droopy4096 requested review from a team, Emyrk, ibetitsmike, jdomeracki-coder, johnstcn, nickvigilante and spikecurtis as code owners October 15, 2026 15:55
@github-actions github-actions Bot assigned droopy4096 Oct 15, 2026
@droopy4096
droopy4096 changed the base branch from main to release/2.34 October 15, 2026 15:56
@github-actions

github-actions Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

👋 Hey @droopy4096!

This PR is targeting the release/2.34 release branch, but its title does not start with fix: or fix(scope):.

Only bug fixes should be cherry-picked to release branches. If this is a bug fix, please update the PR title to match the conventional commit format:

fix: description of the bug fix
fix(scope): description of the bug fix

If this is not a bug fix, it likely should not target a release branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@droopy4096 droopy4096 changed the title Dm fix nix 2.34 Remove Nix from matrix in 2.34 Oct 15, 2026
@linear-code

linear-code Bot commented Oct 15, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

ENT-214

ENT-215

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@droopy4096
Remove remainder of Nix references since it's not part of matrix
ad26aa5
@droopy4096 droopy4096 changed the title Remove Nix from matrix in 2.34 ci(.github/workflows): remove nix from dogfood image matrix (backport 2.34) Oct 15, 2026
@coder
coder Bot requested a review from denisra October 15, 2026 16:12
@denisra

denisra commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

Not a blocker, but we are not using chromatic anymore, so we'll need a separate PR to drop it from every release branch where it's still active. This is just a note for us to follow up on later.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

denisra
denisra approved these changes Oct 15, 2026
View reviewed changes
@droopy4096
droopy4096 merged commit 879323c into release/2.34 Oct 15, 2026
37 of 40 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@droopy4096
droopy4096 deleted the dm-fix-nix-2.34 branch October 15, 2026 17:56
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@denisra denisra denisra approved these changes
@nickvigilante nickvigilante Awaiting requested review from nickvigilante
@ibetitsmike ibetitsmike Awaiting requested review from ibetitsmike
@johnstcn johnstcn Awaiting requested review from johnstcn
@jdomeracki-coder jdomeracki-coder Awaiting requested review from jdomeracki-coder jdomeracki-coder is a code owner
@Emyrk Emyrk Awaiting requested review from Emyrk
@spikecurtis spikecurtis Awaiting requested review from spikecurtis

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@droopy4096 droopy4096

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@droopy4096 @denisra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.