GeezerVison is showing github.com — test(coderd/notifications/dispatch/smtptest): renew the expired TLS test certificate by ibetitsmike · Pull Request #30922 · coder/coder
Conversation
Renews the SMTP test server certificate in coderd/notifications/dispatch/smtptest/fixtures. It expired on 2026-10-18 at 13:36:08Z, so the TLS cases of TestSMTP (TLS:_self-signed, TLS:_self-signed_+_SNI, PLAIN_auth_and_TLS) fail in test-go-pg-17 and test-go-race-pg on every PR.
What changed
server.crt: the committed server.csr, re-signed with the committed CA (ca.crt, ca.key) and v3_ext.conf. It is valid until 2034-07-12, a day before the CA expires. The key pair, subject, and extensions (SANs myserver.local, www.myserver.local, 127.0.0.1) are unchanged. Only the serial, the validity, and the signature differ.
ca.srl: the next serial, which the new certificate uses.
generate.sh: it issued the server certificate for 825 days, and 2024-07-15 plus 825 days is 2026-10-18. It now uses 3649 days, a day less than the CA's 3650.
The command, run in the fixtures directory:
openssl x509 -req -in server.csr -CA ca.crt -CAkey ca.key -set_serial 0x0330C6D190E3FE649DAFCDA2F4D765E2D29328DF -out server.crt -days 2824 -extfile v3_ext.conf
With OpenSSL 3.0.2, -CAserial ca.srl issued a random serial and left ca.srl unchanged, so the command sets the next serial explicitly.
Review focus
Re-signing keeps the CA and the server key, so no other fixture or test changes. The one choice is the validity: about 7.7 years, ending a day before the CA.
Validation
| Check |
main |
This PR |
openssl x509 -noout -dates |
notAfter=Oct 18 13:36:08 2026 GMT |
notAfter=Jul 12 14:24:37 2034 GMT |
openssl verify -CAfile ca.crt server.crt |
certificate has expired |
server.crt: OK |
go test ./coderd/notifications/dispatch/... -run TestSMTP -count=1 |
the 3 TLS cases fail with x509: certificate has expired or is not yet valid |
pass |
go test ./coderd/notifications/... -count=1 passes, including notifications_test.go, the other user of smtptest. A text diff of the old and new certificates (openssl x509 -noout -text) shows only the serial, the dates, and the signature.
Xum, an AI agent, opened this PR for @ibetitsmike and wrote this description.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
chatgpt-codex-connector[bot] reacted with thumbs up emoji
…est certificate
The SMTP test server certificate expired on 2026-10-18 at 13:36:08Z,
825 days after it was issued, so the TLS cases of TestSMTP fail.
Re-sign the committed server.csr with the committed CA, valid until
2034-07-12, a day before the CA expires. The key pair, subject, and
extensions are unchanged, and the serial is the next one in ca.srl.
generate.sh now issues the server certificate for 3649 days, a day
less than the CA.
Codex Review Summary
This comment shows the latest Codex review activity on this pull request.
| Review |
Status |
Commit |
Review trigger |
| 📝 Code Review |
✅ Completed 2026-10-18T16:46:40.079091Z |
89313e4 |
Draft marked ready |
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review" or "@codex security review".
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|