GeezerVison is showing github.com — feat: graduate chat projects out of the chat-projects experiment by f0ssel · Pull Request #31354 · coder/coder
Conversation
Graduates chat projects out of the chat-projects experiment so they are always on (early access). Every backend and frontend gate is removed: project routes, the project_id checks on list/create/update chats, project instructions, skills, and memory in chatd, and all experiments.includes("chat-projects") checks in the Agents UI.
Project sharing is the exception: the project ACL endpoints (GET/PATCH /api/experimental/organizations/{organization}/chats/projects/{project}/acl) now require a new safe experiment, chat-project-sharing. There is no project-sharing UI yet.
Notes for reviewers:
- Only the ACL endpoints are gated. Shares created before this change still grant access when
chat-project-sharing is off. This is intentional.
- Like the old gate,
RequireExperimentWithDevBypass skips the check in dev builds, so tests cannot observe it.
- Tests that asserted experiment-off behavior were removed. Sidebar and layout stories now stub
getChatProjects, since the sidebar always fetches projects.
- A dedicated projects docs page is in docs(docs): add Coder Agents projects page #30684, which edits the same line in
extending-agents.md and will conflict.
Decision log
- Removed
ExperimentChatProjects entirely instead of keeping a no-op constant. A deployment that still sets CODER_EXPERIMENTS=chat-projects gets the existing "ignoring unknown experiment" warning.
- Gated only the
/acl sub-route with chat-project-sharing, using the same middleware the old experiment used.
- Kept the
--disable-chat-sharing deployment check inside the ACL handlers, so both must allow sharing.
- Left
chatProjectsEnabled in ChatsSidebar.tsx as is. It now means "the user has an organization", but the name predates this PR.
- Checks run: Go build, vet, and golangci-lint on the changed packages;
./coderd/x/chatd/..., ./codersdk/..., ./coderd -run Chat, and the enterprise chat project tests; site tsc, biome, the AgentsPage unit tests, and the affected Storybook files. The frontend-deep-review and doc-check self-checks found nothing blocking after fixes.
Generated by Coder Agents on behalf of @f0ssel.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Chat projects are always on. Project sharing endpoints now require the
new safe chat-project-sharing experiment.
Docs preview
Check off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
jaaydenh
Awaiting requested review from jaaydenh
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|
nickvigilante
left a comment