GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — docs: own the legacy /docs/templates and /docs/workspaces redirects on 2.39 by coder[bot] · Pull Request #31787 · coder/coder

Conversation

@coder

@coder coder Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Moves four legacy redirects into release/2.39's docs/redirects.json, so they apply only while 2.39 is the docs mainline:

Source Destination
/docs/templates /docs/admin/templates
/docs/templates/open-in-coder /docs/admin/templates/open-in-coder
/docs/templates/troubleshooting /docs/admin/templates/troubleshooting
/docs/workspaces /docs/user-guides/workspace-management

Today the same rules live in coder.com's and docs-engine's static redirect files, which apply whatever the mainline is. On main, #31645 moves Templates back to docs/templates/ and adds admin/templates/* → templates/*, so once 2.40 is the mainline the static rules loop. coder/coder.com#1201 and coder/docs-engine#304 remove them, but on their own they'd leave these URLs returning 404 on 2.39 until 2.40 ships.

With the rules here instead:

  • coder.com reads the mainline branch's docs/redirects.json for unversioned /docs, so the four URLs keep redirecting while 2.39 is mainline and stop when 2.40 takes over, with no merge to time.
  • The router applies a version's own rules on a miss, only when the destination page exists, so /docs/v2.39/templates keeps redirecting after 2.40 ships too.

Merge order

  1. This PR. It's safe alone: coder.com's static rules run first and point to the same places.
  2. After coder.com rebuilds with this commit pinned and docs-engine republishes 2.39, confirm /docs/templates still lands on /docs/admin/templates.
  3. Merge coder/coder.com#1201 and coder/docs-engine#304.

Testing

  • go run ./scripts/docsredirectscheck on this branch: docs/redirects.json: 5 rules OK. Destinations are pages in 2.39's manifest, no source is a live page, and there are no chains.
  • docs-engine's parseVersionRedirectsFile, the publisher's parser, accepts the file and normalizes all five rules.

Refs DOCS-1479.

Note

Opened by Superblink on behalf of @nickvigilante.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@coder
docs: own the legacy /docs/templates and /docs/workspaces redirects o…
e93bf0d
…n 2.39

Moves four rules from the coder.com and docs-engine static redirect files into release/2.39 docs/redirects.json, so they apply only while 2.39 is the mainline. On 2.40, docs/templates and docs/workspaces are real pages and these rules would loop against main docs/redirects.json.

Refs DOCS-1479
@coder coder Bot assigned nickvigilante Nov 5, 2026
@linear-code

linear-code Bot commented Nov 5, 2026

Copy link
Copy Markdown

DOCS-1479

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot added the community Pull Requests and issues created by the community. label Nov 5, 2026
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

👋 Hey @coder[bot]!

This PR is targeting the release/2.39 release branch, but its title does not start with fix: or fix(scope):.

Only bug fixes should be cherry-picked to release branches. If this is a bug fix, please update the PR title to match the conventional commit format:

fix: description of the bug fix
fix(scope): description of the bug fix

If this is not a bug fix, it likely should not target a release branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nickvigilante
nickvigilante approved these changes Nov 5, 2026
View reviewed changes
@nickvigilante
nickvigilante requested a review from denisra November 5, 2026 16:22
@nickvigilante

nickvigilante commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

👋 Hey @coder[bot]!

This PR is targeting the release/2.39 release branch, but its title does not start with fix: or fix(scope):.

Only bug fixes should be cherry-picked to release branches. If this is a bug fix, please update the PR title to match the conventional commit format:

fix: description of the bug fix
fix(scope): description of the bug fix

If this is not a bug fix, it likely should not target a release branch.

I think we should also allow docs here. It's not unheard of that I need to make a change to docs on a release branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

denisra
denisra approved these changes Nov 9, 2026
View reviewed changes
@nickvigilante

nickvigilante commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

@denisra Thanks for the review! I'm still blocked from merging to this branch, so can you merge this PR when convenient for you?

denisra reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@denisra
denisra merged commit 6e6ab22 into release/2.39 Nov 10, 2026
54 of 55 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@denisra
denisra deleted the docs/release-2.39-legacy-templates-redirects branch November 10, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@denisra denisra denisra approved these changes
@nickvigilante nickvigilante nickvigilante approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@nickvigilante nickvigilante

Labels

community Pull Requests and issues created by the community.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@nickvigilante @denisra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.