GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(site/src): raise light theme warning text contrast to 4.5:1 by chrifro · Pull Request #32047 · coder/coder

Conversation

@chrifro

@chrifro chrifro commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

In the light theme, --content-warning was hsl(27 96% 61%) (orange-400, #FB923C). That measures 2.26:1 on --surface-primary and 2.06:1 on --surface-secondary. As a result, warning text such as the navbar proxy latency (DEQ-517, audited at 2.00:1) failed WCAG 1.4.3.

This sets the light value to 17 88% 40% (orange-700, #C03F0C). The light theme already uses that color for --git-modified, and the dark theme already uses one color for both tokens. The dark theme and the four color-blind themes are unchanged.

Background Before After
--surface-primary 2.26:1 5.31:1
--surface-secondary (DEQ-517) 2.06:1 4.83:1
--surface-orange 1.98:1 4.63:1

Every light-theme use of text-content-warning and of the warning StatusIndicator/Alert variants gets the darker color, which Pixel will show. theme/cssVariables.test.ts now checks that --content-warning stays at 4.5:1 or above on the primary, secondary, and orange surfaces in every concrete theme. On the old value, only the two light-theme cases fail.

Before After
ProxyMenu opened, light theme, latency in orange-400 ProxyMenu opened, light theme, latency in orange-700

These are from the Storybook story modules/dashboard/ProxyMenu/Opened in the light theme. The computed latency color changes from rgb(251, 146, 60) to rgb(192, 63, 12).

This supersedes #31443, which is a draft with merge conflicts. This PR carries its token change and addresses @aqandrew's comment there: the WCAG luminance helper now sits at module scope and links to the WCAG definition.

Closes DEQ-517

Decision log
  • Token change, not a call-site fix: the failing color is the shared light --content-warning token. Patching only Latency would leave every other warning label failing.
  • Orange-700: it reuses the existing light --git-modified color and matches the dark-theme pairing. A reviewer pass also computed amber-700 (26 90% 37%). Amber-700 sits further from --content-destructive, but it fails on --surface-orange (4.41:1).
  • Known remaining gap, out of scope: warning text on --surface-tertiary improves from 1.78:1 to 4.18:1 but is still under 4.5:1. This affects the badge count in AIBridgePage/NetworkCallBadges.tsx. The test therefore leaves out --surface-tertiary.
  • Self-review: frontend-deep-review (all eight roles) and an accessibility pass found no blocking or should-fix findings. Two nits are applied: the helper uses Math.max/Math.min, and the test inlines its cases. A third nit, the duplicate luminance helper in ScrollArea.stories.tsx, is not merged here to keep the scope small.

🤖 Generated by Coder Agents on behalf of @chrifro.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@chrifro
fix(site/src): raise light theme warning text contrast to 4.5:1
a38b7bb 
Light --content-warning was orange-400 (2.26:1 on white, 2.06:1 on
--surface-secondary), so warning text such as the navbar proxy latency
failed WCAG 1.4.3. Use orange-700, the light --git-modified color, which
mirrors the dark theme where both tokens already match.

Fixes DEQ-517
@chrifro
chrifro temporarily deployed to main November 11, 2026 12:40 — with GitHub Actions Inactive
@chrifro
chrifro temporarily deployed to main November 11, 2026 12:40 — with GitHub Actions Inactive
@linear-code

linear-code Bot commented Nov 11, 2026

Copy link
Copy Markdown

DEQ-517
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot assigned chrifro Nov 11, 2026
@chrifro
chrifro marked this pull request as ready for review November 11, 2026 12:50
@chrifro
chrifro temporarily deployed to main November 11, 2026 12:50 — with GitHub Actions Inactive

This branch was previously deployed

1 inactive deployment
main — a38b7bbd Deployed Nov 11, 2026 by chrifro via cla #254375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@chrifro chrifro

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@chrifro
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.