GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(site/src/modules/notifications): name the notifications inbox button by chrifro · Pull Request #32048 · coder/coder

Conversation

@chrifro

@chrifro chrifro commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

The notifications bell in the header had no accessible name other than the unread count, so NVDA read it as "1, button", or as a nameless button when nothing was unread. It now gets aria-label "Notifications", or "Notifications, N unread" when the badge shows a count. Callers can still override the label through props.

Closes DEQ-508

Ticket UI surface Screenshots
DEQ-508 Header notifications inbox button (InboxButton) Not visible: only the accessible name changes

Verified with axe-core 4.11 on the InboxButton stories: no violations. The accessibility tree reads button "Notifications, 3 unread" (Unread) and button "Notifications" (AllRead). The new Vitest test fails on main and passes here.

Grouping and decision log
  • Batch label-programmatic-not-descriptive has 3 tickets: DEQ-508 (this PR), DEQ-558 (separate PR, different component), and DEQ-219, which was already fixed on main by fix(site/src): expose the date range picker trigger as a combobox #31940 (the time range picker is now a combobox named "Time range"). DEQ-219 was handed back to a human.
  • Used aria-label on the button instead of sr-only text. Inline sr-only text next to the flex badge risks concatenation without whitespace ("Notifications1"), and aria-label gives one deterministic name.
  • The name uses the exact unread count even above 99, where the badge shows "99+". The badge is a status indicator, not the control's label, and the exact count tells the user more. The deep review raised this and kept it as an intentional choice.
  • Self-review: frontend-review (FE1 to FE10 all PASS), frontend-deep-review (all eight roles, no findings), frontend-accessibility (no violations on the affected stories).

🤖 Generated by Coder Agents on behalf of @chrifro.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@chrifro
fix(site/src/modules/notifications): name the notifications inbox button
ad7caa7
@chrifro
chrifro temporarily deployed to main November 11, 2026 12:54 — with GitHub Actions Inactive
@chrifro
chrifro temporarily deployed to main November 11, 2026 12:54 — with GitHub Actions Inactive
@linear-code

linear-code Bot commented Nov 11, 2026

Copy link
Copy Markdown

DEQ-508
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot assigned chrifro Nov 11, 2026
@chrifro
chrifro marked this pull request as ready for review November 11, 2026 13:05
@chrifro
chrifro temporarily deployed to main November 11, 2026 13:05 — with GitHub Actions Inactive

This branch was previously deployed

1 inactive deployment
main — ad7caa75 Deployed Nov 11, 2026 by chrifro via cla #254394
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@chrifro chrifro

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@chrifro
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.