GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(site/src/pages/CreateUserPage): include descriptions in login type option names by chrifro · Pull Request #32049 · coder/coder

Conversation

@chrifro

@chrifro chrifro commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

The "Login type" options on the Create user page announced only their short label ("Password", "GitHub", "Service account"). The description under each option, which is what tells the user what the login type does, was left out. Each option is now labelled by both its label and its description, for example "Password Use an email address and password to log in."

Radix Select.Item sets aria-labelledby to its ItemText id and lets props override it. So the item now points at its own ItemText id and the description id, both built from useId(). The trigger still shows only the short label as its value, and typeahead still matches the label.

Closes DEQ-558

Ticket UI surface Screenshots
DEQ-558 /deployment/users/create, the Login type dropdown options (CreateUserForm) Not visible: only the accessible names change

Verified with axe-core 4.11 on pages/CreateUserPage with the listbox open. Before, the options were named option "Password", and so on. After, they are named option "Password Use an email address and password to log in.", and so on, with the Premium notice included for the disabled service account option. The trigger is still combobox "Login type": Password. The only violation, aria-hidden-focus on #storybook-root, also shows on main: it is Radix hiding the page behind the open select. The updated Vitest test fails on main and passes here. The e2e helper's getByRole("option", { name: "Password", exact: false }) still matches only the Password option.

Grouping and decision log
  • Batch label-programmatic-not-descriptive has 3 tickets: DEQ-558 (this PR), DEQ-508 (separate PR, different component), and DEQ-219, which was already fixed on main by fix(site/src): expose the date range picker trigger as a combobox #31940. DEQ-219 was handed back to a human.
  • The description goes into the name (aria-labelledby) rather than only aria-describedby, because the ticket asks for it and Deque's guidance says all on-screen text that labels the control belongs in the name.
  • The fix is scoped to this form's hand-assembled items. The shared SelectItem has no description slot, and no other select renders descriptions.
  • Self-review: frontend-review (FE1 to FE10 all PASS), frontend-deep-review (all eight roles, no findings), frontend-accessibility (no new violations).

🤖 Generated by Coder Agents on behalf of @chrifro.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@chrifro
fix(site/src/pages/CreateUserPage): include descriptions in login typ…
a66841e
…e option names
@chrifro
chrifro temporarily deployed to main November 11, 2026 12:54 — with GitHub Actions Inactive
@chrifro
chrifro temporarily deployed to main November 11, 2026 12:54 — with GitHub Actions Inactive
@linear-code

linear-code Bot commented Nov 11, 2026

Copy link
Copy Markdown

DEQ-558

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot assigned chrifro Nov 11, 2026
@chrifro
chrifro marked this pull request as ready for review November 11, 2026 13:05
@chrifro
chrifro temporarily deployed to main November 11, 2026 13:05 — with GitHub Actions Inactive

This branch was previously deployed

1 inactive deployment
main — a66841e4 Deployed Nov 11, 2026 by chrifro via cla #254395
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@chrifro chrifro

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@chrifro
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.