GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||
GeezerVison is showing github.com — fix(site/src/modules/resources): let agent metadata values grow with text spacing by chrifro · Pull Request #32055 · coder/coder Conversation
|
| Ticket | Surface | Screenshots |
|---|---|---|
| DEQ-434 | Workspace page, agent metadata row | before/after |
Repro. I used ./scripts/develop.sh with the docker starter template, whose metadata matches the ticket (CPU Usage, Memory Usage (Host), Load Average (Host)). I injected the WCAG spacing stylesheet after the first render and listed clipped elements. On main, five values were clipped (for example 23.3/147 GiB (16%): scrollWidth 157, width 122). On this branch, nothing is clipped. Default spacing renders the same widths on both.
Coverage. StaticWidth returns early under Storybook (process.env.STORYBOOK), and jsdom has no layout. That leaves an inline-style assertion with a stubbed getBoundingClientRect as the only possible test, and FE1 and FE10 discourage that. I verified in a real browser against the dev server instead.
Not changed. Values keep truncate max-w-64. Text longer than 256px is already cut off at default spacing, so that cap doesn't come from the spacing override. The stale-value branch renders StaticWidth under TooltipTrigger asChild, which replaces the ref, so the effect never pins that element. That's pre-existing and doesn't clip.
Accessibility audit (axe 4.11). The AgentMetadataView story shows a pre-existing color-contrast violation from the stale or disabled value color. This diff doesn't change it.
Dropped deep-review findings.
StaticWidth: dropped. The component still holds a value's width steady across updates, and a rename would add churn to a 5-line fix.Branch name. I used a11y/text-spacing-cut-off-agent-metadata instead of ...-2, because off-2 would auto-link to an issue on Linear's OFF team.
Doc check. No docs describe metadata value widths, so no docs changes are needed.
🤖 Generated by Coder Agents on behalf of @chrifro.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
5f54c0aa
Deployed
At least 1 approving review is required to merge this pull request.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.