GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(site/src/modules/resources): let agent metadata values grow with text spacing by chrifro · Pull Request #32055 · coder/coder

Conversation

@chrifro

@chrifro chrifro commented Nov 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Under WCAG 1.4.12 text spacing overrides, workspace agent metadata values such as "23.3/147 GiB (16%)" and "0.098/13 cores (1%)" were cut off with an ellipsis on the workspace page.

StaticWidth measures each value once and then pinned that measurement as a fixed width in pixels. When a user stylesheet later widened the text, the box kept its old width, and the value stayed clipped until it changed. It now sets minWidth instead. Values still never shrink, so there is no jitter between updates, but they can grow when spacing changes.

Closes DEQ-434

Ticket Surface Screenshots
DEQ-434 Workspace page, agent metadata row before/after
Verification, decisions, and dropped findings

Repro. I used ./scripts/develop.sh with the docker starter template, whose metadata matches the ticket (CPU Usage, Memory Usage (Host), Load Average (Host)). I injected the WCAG spacing stylesheet after the first render and listed clipped elements. On main, five values were clipped (for example 23.3/147 GiB (16%): scrollWidth 157, width 122). On this branch, nothing is clipped. Default spacing renders the same widths on both.

Coverage. StaticWidth returns early under Storybook (process.env.STORYBOOK), and jsdom has no layout. That leaves an inline-style assertion with a stubbed getBoundingClientRect as the only possible test, and FE1 and FE10 discourage that. I verified in a real browser against the dev server instead.

Not changed. Values keep truncate max-w-64. Text longer than 256px is already cut off at default spacing, so that cap doesn't come from the spacing override. The stale-value branch renders StaticWidth under TooltipTrigger asChild, which replaces the ref, so the effect never pins that element. That's pre-existing and doesn't clip.

Accessibility audit (axe 4.11). The AgentMetadataView story shows a pre-existing color-contrast violation from the stale or disabled value color. This diff doesn't change it.

Dropped deep-review findings.

  • TN5 (nit), rename StaticWidth: dropped. The component still holds a value's width steady across updates, and a rename would add churn to a 5-line fix.

Branch name. I used a11y/text-spacing-cut-off-agent-metadata instead of ...-2, because off-2 would auto-link to an issue on Linear's OFF team.

Doc check. No docs describe metadata value widths, so no docs changes are needed.

🤖 Generated by Coder Agents on behalf of @chrifro.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@chrifro
fix(site/src/modules/resources): let agent metadata values grow with …
705be8c
…text spacing
@linear-code

linear-code Bot commented Nov 11, 2026

Copy link
Copy Markdown

DEQ-434

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@chrifro
chrifro temporarily deployed to main November 11, 2026 14:57 — with GitHub Actions Inactive
@chrifro
chrifro temporarily deployed to main November 11, 2026 14:57 — with GitHub Actions Inactive
@github-actions github-actions Bot assigned chrifro Nov 11, 2026
@chrifro
chrifro temporarily deployed to main November 11, 2026 15:00 — with GitHub Actions Inactive
@chrifro
chrifro marked this pull request as ready for review November 11, 2026 15:07
@chrifro
chrifro temporarily deployed to main November 11, 2026 15:07 — with GitHub Actions Inactive
@chrifro
Merge branch 'main' into a11y/text-spacing-cut-off-agent-metadata
5f54c0a
@chrifro
chrifro requested a review from aqandrew November 12, 2026 13:40
@chrifro
chrifro temporarily deployed to main November 12, 2026 13:40 — with GitHub Actions Inactive
@chrifro chrifro mentioned this pull request Nov 12, 2026
fix(site/src): show truncated filter labels in a tooltip #32054
Open

This branch was previously deployed

1 inactive deployment
main — 5f54c0aa Deployed Nov 12, 2026 by chrifro via cla #254938
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aqandrew aqandrew Awaiting requested review from aqandrew

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@chrifro chrifro

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@chrifro
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.